diff --git a/.github/workflows/no_print_in_dart.yaml b/.github/workflows/no_print_in_dart.yaml index b321a9cc9..b1c356c31 100644 --- a/.github/workflows/no_print_in_dart.yaml +++ b/.github/workflows/no_print_in_dart.yaml @@ -11,7 +11,7 @@ jobs: - name: Check for print() statements in dart code (use printV() instead) if: github.event_name == 'pull_request' run: | - GIT_GREP_OUT="$(git grep ' print(' | (grep .dart: || test $? = 1) | (grep -v print_verbose.dart || test $? = 1) || true)" + GIT_GREP_OUT="$(git grep ' print(' | (grep .dart: || test $? = 1) | (grep -v print_verbose.dart || test $? = 1) | (grep -v print_verbose_dummy.dart || test $? = 1) || true)" [[ "x$GIT_GREP_OUT" == "x" ]] && exit 0 echo "$GIT_GREP_OUT" echo "There are .dart files which use print() statements" diff --git a/cw_core/lib/utils/print_verbose.dart b/cw_core/lib/utils/print_verbose.dart index de7cc8557..42014d609 100644 --- a/cw_core/lib/utils/print_verbose.dart +++ b/cw_core/lib/utils/print_verbose.dart @@ -1,4 +1,5 @@ import 'dart:math'; +import 'package:flutter/foundation.dart'; void printV(dynamic content) { CustomTrace programInfo = CustomTrace(StackTrace.current); @@ -20,7 +21,7 @@ class CustomTrace { try { _parseTrace(); } catch (e) { - print("Unable to parse trace (printV): $e"); + if (kDebugMode) print("Unable to parse trace (printV): $e"); } } @@ -80,7 +81,7 @@ class CustomTrace { columnStr = columnStr.replaceFirst(")", ""); this.columnNumber = int.tryParse(columnStr); } catch (e) { - print("Unable to parse trace (printV): $e"); + if (kDebugMode) print("Unable to parse trace (printV): $e"); } } } diff --git a/tool/append_translation.dart b/tool/append_translation.dart index 8ef646502..b4c975599 100644 --- a/tool/append_translation.dart +++ b/tool/append_translation.dart @@ -1,4 +1,3 @@ -import 'package:cw_core/utils/print_verbose.dart'; import 'utils/translation/arb_file_utils.dart'; import 'utils/translation/translation_constants.dart'; diff --git a/tool/download_moneroc_prebuilds.dart b/tool/download_moneroc_prebuilds.dart index 378d9293b..8889a1bc1 100644 --- a/tool/download_moneroc_prebuilds.dart +++ b/tool/download_moneroc_prebuilds.dart @@ -1,6 +1,6 @@ import 'dart:io'; -import 'package:cw_core/utils/print_verbose.dart'; +import './print_verbose_dummy.dart'; import 'package:dio/dio.dart'; import 'package:archive/archive_io.dart'; diff --git a/tool/generate_localization.dart b/tool/generate_localization.dart index 0f9af8366..0e07dc2c3 100644 --- a/tool/generate_localization.dart +++ b/tool/generate_localization.dart @@ -1,6 +1,6 @@ import 'dart:io'; import 'dart:convert'; -import 'package:cw_core/utils/print_verbose.dart'; +import './print_verbose_dummy.dart'; import 'localization/localization_constants.dart'; import 'utils/utils.dart'; diff --git a/tool/print_verbose_dummy.dart b/tool/print_verbose_dummy.dart new file mode 100644 index 000000000..f7286e1f9 --- /dev/null +++ b/tool/print_verbose_dummy.dart @@ -0,0 +1 @@ +void printV(dynamic content) => print(content); \ No newline at end of file diff --git a/tool/translation_add_lang.dart b/tool/translation_add_lang.dart index 96f22158d..e3c372a8c 100644 --- a/tool/translation_add_lang.dart +++ b/tool/translation_add_lang.dart @@ -1,6 +1,6 @@ import 'dart:io'; -import 'package:cw_core/utils/print_verbose.dart'; +import './print_verbose_dummy.dart'; import 'utils/translation/arb_file_utils.dart'; import 'utils/translation/translation_constants.dart'; diff --git a/tool/translation_consistence.dart b/tool/translation_consistence.dart index df24cce15..2cdd358c8 100644 --- a/tool/translation_consistence.dart +++ b/tool/translation_consistence.dart @@ -1,6 +1,6 @@ import 'dart:io'; -import 'package:cw_core/utils/print_verbose.dart'; +import './print_verbose_dummy.dart'; import 'utils/translation/arb_file_utils.dart'; import 'utils/translation/translation_constants.dart'; diff --git a/tool/utils/translation/arb_file_utils.dart b/tool/utils/translation/arb_file_utils.dart index 0fe31d85d..92a8f6e2e 100644 --- a/tool/utils/translation/arb_file_utils.dart +++ b/tool/utils/translation/arb_file_utils.dart @@ -1,7 +1,7 @@ import 'dart:convert'; import 'dart:io'; -import 'package:cw_core/utils/print_verbose.dart'; +import '../../print_verbose_dummy.dart'; void appendStringToArbFile(String fileName, String name, String text, {bool force = false}) { final file = File(fileName);