android-apps-mirrors/SimpleX-Chat
0
0
Fork 0
mirror of https://github.com/simplex-chat/simplex-chat.git synced 2025-06-28 20:29:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

android, desktop: fix group members duplicates (#5727)

Browse source 
* android, desktop: fix group members duplicates

* optimization

* use groupMemberId as key

---------

Co-authored-by: Evgeny Poberezkin <evgeny@poberezkin.com>
This commit is contained in:
Stanislav Dmitrenko 2025-03-07 23:49:55 +07:00 • committed by GitHub
parent 27f63dafaa
commit 3412ceba01
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 6 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
apps/multiplatform/common/src/commonMain/kotlin/chat/simplex/common/model/ChatModel.kt
View file

@ -789,6 +789,11 @@ object ChatModel {
} }
// update current chat // update current chat
return if (chatId.value == groupInfo.id) { return if (chatId.value == groupInfo.id) {
if (groupMembers.value.isNotEmpty() && groupMembers.value.firstOrNull()?.groupId != groupInfo.groupId) {
// stale data, should be cleared at that point, otherwise, duplicated items will be here which will produce crashes in LazyColumn
groupMembers.value = emptyList()
groupMembersIndexes.value = emptyMap()
}
val memberIndex = groupMembersIndexes.value[member.groupMemberId] val memberIndex = groupMembersIndexes.value[member.groupMemberId]
val updated = chatItems.value.map { val updated = chatItems.value.map {
// Take into account only specific changes, not all. Other member updates are not important and can be skipped // Take into account only specific changes, not all. Other member updates are not important and can be skipped

2
apps/multiplatform/common/src/commonMain/kotlin/chat/simplex/common/views/chat/group/GroupMentions.kt
View file

@ -196,7 +196,7 @@ fun GroupMentions(
MaxMentionsReached() MaxMentionsReached()
} }
} }
itemsIndexed(filteredMembers.value, key = { _, item -> item.memberId }) { i, member -> itemsIndexed(filteredMembers.value, key = { _, item -> item.groupMemberId }) { i, member ->
if (i != 0 || !showMaxReachedBox) { if (i != 0 || !showMaxReachedBox) {
Divider() Divider()
} }