Add ability to search in account names

This commit is contained in:
Michael Schättgen 2019-09-11 20:51:02 +02:00
parent 1d513441c6
commit 445410fcd7
7 changed files with 38 additions and 1 deletions

View file

@ -19,6 +19,8 @@ public class Preferences {
return _prefs.getBoolean("pref_tap_to_reveal", false); return _prefs.getBoolean("pref_tap_to_reveal", false);
} }
public boolean isSearchAccountNameEnabled() { return _prefs.getBoolean("pref_search_names", false); }
public boolean isSecureScreenEnabled() { public boolean isSecureScreenEnabled() {
// screen security should be enabled by default, but not for debug builds // screen security should be enabled by default, but not for debug builds
return _prefs.getBoolean("pref_secure_screen", !BuildConfig.DEBUG); return _prefs.getBoolean("pref_secure_screen", !BuildConfig.DEBUG);

View file

@ -101,6 +101,7 @@ public class MainActivity extends AegisActivity implements EntryListView.Listene
_entryListView = (EntryListView) getSupportFragmentManager().findFragmentById(R.id.key_profiles); _entryListView = (EntryListView) getSupportFragmentManager().findFragmentById(R.id.key_profiles);
_entryListView.setListener(this); _entryListView.setListener(this);
_entryListView.setShowAccountName(getPreferences().isAccountNameVisible()); _entryListView.setShowAccountName(getPreferences().isAccountNameVisible());
_entryListView.setSearchAccountName(getPreferences().isSearchAccountNameEnabled());
_entryListView.setTapToReveal(getPreferences().isTapToRevealEnabled()); _entryListView.setTapToReveal(getPreferences().isTapToRevealEnabled());
_entryListView.setTapToRevealTime(getPreferences().getTapToRevealTime()); _entryListView.setTapToRevealTime(getPreferences().getTapToRevealTime());
_entryListView.setSortCategory(getPreferences().getCurrentSortCategory(), false); _entryListView.setSortCategory(getPreferences().getCurrentSortCategory(), false);
@ -216,10 +217,12 @@ public class MainActivity extends AegisActivity implements EntryListView.Listene
recreate(); recreate();
} else if (data.getBooleanExtra("needsRefresh", false)) { } else if (data.getBooleanExtra("needsRefresh", false)) {
boolean showAccountName = getPreferences().isAccountNameVisible(); boolean showAccountName = getPreferences().isAccountNameVisible();
boolean searchAccountName = getPreferences().isSearchAccountNameEnabled();
boolean tapToReveal = getPreferences().isTapToRevealEnabled(); boolean tapToReveal = getPreferences().isTapToRevealEnabled();
int tapToRevealTime = getPreferences().getTapToRevealTime(); int tapToRevealTime = getPreferences().getTapToRevealTime();
ViewMode viewMode = getPreferences().getCurrentViewMode(); ViewMode viewMode = getPreferences().getCurrentViewMode();
_entryListView.setShowAccountName(showAccountName); _entryListView.setShowAccountName(showAccountName);
_entryListView.setSearchAccountName(searchAccountName);
_entryListView.setTapToReveal(tapToReveal); _entryListView.setTapToReveal(tapToReveal);
_entryListView.setTapToRevealTime(tapToRevealTime); _entryListView.setTapToRevealTime(tapToRevealTime);
_entryListView.setViewMode(viewMode); _entryListView.setViewMode(viewMode);

View file

@ -201,6 +201,12 @@ public class PreferencesFragment extends PreferenceFragmentCompat {
} }
}); });
Preference searchAccountNamePreference = findPreference("pref_search_names");
searchAccountNamePreference.setOnPreferenceChangeListener((preference, newValue) -> {
_result.putExtra("needsRefresh", true);
return true;
});
Preference tapToRevealPreference = findPreference("pref_tap_to_reveal"); Preference tapToRevealPreference = findPreference("pref_tap_to_reveal");
tapToRevealPreference.setOnPreferenceChangeListener((preference, newValue) -> { tapToRevealPreference.setOnPreferenceChangeListener((preference, newValue) -> {
_result.putExtra("needsRefresh", true); _result.putExtra("needsRefresh", true);

View file

@ -26,6 +26,7 @@ public class EntryAdapter extends RecyclerView.Adapter<EntryHolder> implements I
private List<DatabaseEntry> _shownEntries; private List<DatabaseEntry> _shownEntries;
private DatabaseEntry _selectedEntry; private DatabaseEntry _selectedEntry;
private boolean _showAccountName; private boolean _showAccountName;
private boolean _searchAccountName;
private boolean _tapToReveal; private boolean _tapToReveal;
private int _tapToRevealTime; private int _tapToRevealTime;
private String _groupFilter; private String _groupFilter;
@ -63,6 +64,8 @@ public class EntryAdapter extends RecyclerView.Adapter<EntryHolder> implements I
_tapToRevealTime = number; _tapToRevealTime = number;
} }
public void setSearchAccountName(boolean searchAccountName) { _searchAccountName = searchAccountName; }
public DatabaseEntry getEntryAt(int position) { public DatabaseEntry getEntryAt(int position) {
return _shownEntries.get(position); return _shownEntries.get(position);
} }
@ -153,12 +156,17 @@ public class EntryAdapter extends RecyclerView.Adapter<EntryHolder> implements I
private boolean isEntryFiltered(DatabaseEntry entry) { private boolean isEntryFiltered(DatabaseEntry entry) {
String group = entry.getGroup(); String group = entry.getGroup();
String issuer = entry.getIssuer().toLowerCase(); String issuer = entry.getIssuer().toLowerCase();
String name = entry.getName().toLowerCase();
if (_groupFilter != null && (group == null || !group.equals(_groupFilter))) { if (_groupFilter != null && (group == null || !group.equals(_groupFilter))) {
return true; return true;
} }
return _searchFilter != null && !issuer.contains(_searchFilter); if (_searchFilter == null) {
return false;
}
return !issuer.contains(_searchFilter) && !(_searchAccountName && name.contains(_searchFilter));
} }
public void refresh(boolean hard) { public void refresh(boolean hard) {

View file

@ -211,6 +211,10 @@ public class EntryListView extends Fragment implements EntryAdapter.Listener {
_adapter.setShowAccountName(showAccountName); _adapter.setShowAccountName(showAccountName);
} }
public void setSearchAccountName(boolean searchAccountName) {
_adapter.setSearchAccountName(searchAccountName);
}
public void setTapToReveal(boolean tapToReveal) { public void setTapToReveal(boolean tapToReveal) {
_adapter.setTapToReveal(tapToReveal); _adapter.setTapToReveal(tapToReveal);
} }

View file

@ -14,6 +14,7 @@
<string name="settings">Preferences</string> <string name="settings">Preferences</string>
<string name="pref_appearance_group_title">Appearance</string> <string name="pref_appearance_group_title">Appearance</string>
<string name="pref_general_group_title">General</string>
<string name="pref_security_group_title">Security</string> <string name="pref_security_group_title">Security</string>
<string name="pref_tools_group_title">Tools</string> <string name="pref_tools_group_title">Tools</string>
<string name="pref_select_theme_title">Theme</string> <string name="pref_select_theme_title">Theme</string>
@ -155,6 +156,8 @@
<string name="group_name_hint">Group name</string> <string name="group_name_hint">Group name</string>
<string name="preference_manage_groups">Edit groups</string> <string name="preference_manage_groups">Edit groups</string>
<string name="preference_manage_groups_summary">Manage and delete your groups here</string> <string name="preference_manage_groups_summary">Manage and delete your groups here</string>
<string name="pref_search_name_title">Search in account names</string>
<string name="pref_search_name_summary">Include account name matches in the search results</string>
<string name="tap_to_reveal">Hidden</string> <string name="tap_to_reveal">Hidden</string>
<string name="selected">Selected</string> <string name="selected">Selected</string>
<string name="dark_theme_title">Dark theme</string> <string name="dark_theme_title">Dark theme</string>

View file

@ -42,6 +42,17 @@
app:iconSpaceReserved="false"/> app:iconSpaceReserved="false"/>
</PreferenceCategory> </PreferenceCategory>
<PreferenceCategory
android:title="@string/pref_general_group_title"
app:iconSpaceReserved="false">
<androidx.preference.SwitchPreferenceCompat
android:defaultValue="false"
android:key="pref_search_names"
android:title="@string/pref_search_name_title"
android:summary="@string/pref_search_name_summary"
app:iconSpaceReserved="false"/>
</PreferenceCategory>
<PreferenceCategory <PreferenceCategory
android:title="@string/pref_security_group_title" android:title="@string/pref_security_group_title"
app:iconSpaceReserved="false"> app:iconSpaceReserved="false">