luckyimnotanigger/Aegis
1
0
Fork 0
mirror of https://github.com/beemdevelopment/Aegis.git synced 2025-04-24 15:56:07 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Check for the possibility of an overflow when parsing OTP period

Browse source 
The conversion of the OTP period value to milliseconds may overflow for large
values, causing the result to wrap around to Integer.MIN_VALUE. This
subsequently caused a crash when calling ObjectAnimator.setDuration.
This commit is contained in:
Alexander Bakker 2019-08-28 19:46:47 +02:00
parent 9cb9d47857
commit 58d13ba9e3
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
app/src/main/java/com/beemdevelopment/aegis/otp/TotpInfo.java
View file

@ -55,7 +55,12 @@ public class TotpInfo extends OtpInfo {
} }
public static boolean isPeriodValid(int period) { public static boolean isPeriodValid(int period) {
return period > 0; if (period <= 0) {
return false;
}
// check for the possibility of an overflow when converting to milliseconds
return period <= Integer.MAX_VALUE / 1000;
} }
public void setPeriod(int period) throws OtpInfoException { public void setPeriod(int period) throws OtpInfoException {