luckyimnotanigger/Aegis
1
0
Fork 0
mirror of https://github.com/beemdevelopment/Aegis.git synced 2025-06-07 23:27:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #1490 from alexbakker/fix-pack-crash

Browse source 
Fix a crash that could occur when deleting a broken icon pack import
This commit is contained in:
Michael Schättgen 2024-09-16 22:58:03 +02:00 • committed by GitHub
commit e63ec4d1e8
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 5 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

10
app/src/main/java/com/beemdevelopment/aegis/ui/fragments/preferences/IconPacksManagerFragment.java
View file

@ -107,15 +107,7 @@ public class IconPacksManagerFragment extends Fragment implements IconPackAdapte
.setMessage(R.string.remove_icon_pack_description) .setMessage(R.string.remove_icon_pack_description)
.setIconAttribute(android.R.attr.alertDialogIcon) .setIconAttribute(android.R.attr.alertDialogIcon)
.setPositiveButton(android.R.string.yes, (dialog, whichButton) -> { .setPositiveButton(android.R.string.yes, (dialog, whichButton) -> {
try { removeIconPack(pack);
_iconPackManager.removeIconPack(pack);
} catch (IconPackException e) {
e.printStackTrace();
Dialogs.showErrorDialog(requireContext(), R.string.icon_pack_delete_error, e);
return;
}
_adapter.removeIconPack(pack);
updateEmptyState();
}) })
.setNegativeButton(android.R.string.no, null) .setNegativeButton(android.R.string.no, null)
.create()); .create());

6
app/src/main/java/com/beemdevelopment/aegis/ui/views/IconPackAdapter.java
View file

@ -35,8 +35,10 @@ public class IconPackAdapter extends RecyclerView.Adapter<IconPackHolder> {
public void removeIconPack(IconPack pack) { public void removeIconPack(IconPack pack) {
int position = _iconPacks.indexOf(pack); int position = _iconPacks.indexOf(pack);
_iconPacks.remove(position); if (position >= 0) {
notifyItemRemoved(position); _iconPacks.remove(position);
notifyItemRemoved(position);
}
} }
@NonNull @NonNull