From 0c63635a3c8cd087f4bbeb62de1ae09be5ce1b7e Mon Sep 17 00:00:00 2001 From: dslul Date: Thu, 6 Feb 2020 10:38:36 +0100 Subject: [PATCH] Reduce popup size and remove popup anim delay popups are still too slow when typing fast. Needs to be improved --- app/build.gradle | 2 +- app/proguard-rules.pro | 17 +++++++++++++++++ .../internal/KeyPreviewChoreographer.java | 2 +- .../inputmethod/latin/InputAttributes.java | 2 +- .../openboard/inputmethod/latin/Suggest.java | 2 ++ ..._key_feedback_background_lxx_dark_border.xml | 2 +- app/src/main/res/values/config-common.xml | 12 ++++++------ app/src/main/res/values/config.xml | 4 ++-- app/src/main/res/values/gesture-input.xml | 2 +- 9 files changed, 32 insertions(+), 13 deletions(-) create mode 100644 app/proguard-rules.pro diff --git a/app/build.gradle b/app/build.gradle index ee92d65c7..c168887e1 100755 --- a/app/build.gradle +++ b/app/build.gradle @@ -9,7 +9,7 @@ android { applicationId "org.dslul.openboard.inputmethod.latin" minSdkVersion 19 targetSdkVersion 29 - versionCode 9 + versionCode 10 versionName "1.3" } diff --git a/app/proguard-rules.pro b/app/proguard-rules.pro new file mode 100644 index 000000000..f7bfc889b --- /dev/null +++ b/app/proguard-rules.pro @@ -0,0 +1,17 @@ +# Add project specific ProGuard rules here. +# By default, the flags in this file are appended to flags specified +# in /home/iwo/android-sdk/tools/proguard/proguard-android.txt +# You can edit the include path and order by changing the proguardFiles +# directive in build.gradle. +# +# For more details, see +# http://developer.android.com/guide/developing/tools/proguard.html + +# Add any project specific keep options here: + +# If your project uses WebView with JS, uncomment the following +# and specify the fully qualified class name to the JavaScript interface +# class: +#-keepclassmembers class fqcn.of.javascript.interface.for.webview { +# public *; +#} diff --git a/app/src/main/java/org/dslul/openboard/inputmethod/keyboard/internal/KeyPreviewChoreographer.java b/app/src/main/java/org/dslul/openboard/inputmethod/keyboard/internal/KeyPreviewChoreographer.java index cd6dbe5fa..b99026aaa 100644 --- a/app/src/main/java/org/dslul/openboard/inputmethod/keyboard/internal/KeyPreviewChoreographer.java +++ b/app/src/main/java/org/dslul/openboard/inputmethod/keyboard/internal/KeyPreviewChoreographer.java @@ -132,7 +132,7 @@ public final class KeyPreviewChoreographer { keyPreviewView.setPreviewBackground(hasMoreKeys, keyPreviewPosition); // The key preview is placed vertically above the top edge of the parent key with an // arbitrary offset. - final int previewY = key.getY() - previewHeight + mParams.mPreviewOffset + final int previewY = key.getY() - previewHeight + key.getHeight() + CoordinateUtils.y(originCoords); ViewLayoutUtils.placeViewAt( diff --git a/app/src/main/java/org/dslul/openboard/inputmethod/latin/InputAttributes.java b/app/src/main/java/org/dslul/openboard/inputmethod/latin/InputAttributes.java index 9e641f5e7..00b203a71 100644 --- a/app/src/main/java/org/dslul/openboard/inputmethod/latin/InputAttributes.java +++ b/app/src/main/java/org/dslul/openboard/inputmethod/latin/InputAttributes.java @@ -107,7 +107,7 @@ public final class InputAttributes { || InputTypeUtils.isEmailVariation(variation) || InputType.TYPE_TEXT_VARIATION_URI == variation || InputType.TYPE_TEXT_VARIATION_FILTER == variation - || flagNoSuggestions + //|| flagNoSuggestions || flagAutoComplete; mShouldShowSuggestions = !shouldSuppressSuggestions; diff --git a/app/src/main/java/org/dslul/openboard/inputmethod/latin/Suggest.java b/app/src/main/java/org/dslul/openboard/inputmethod/latin/Suggest.java index a98a0a48a..9a908f4e6 100644 --- a/app/src/main/java/org/dslul/openboard/inputmethod/latin/Suggest.java +++ b/app/src/main/java/org/dslul/openboard/inputmethod/latin/Suggest.java @@ -17,6 +17,7 @@ package org.dslul.openboard.inputmethod.latin; import android.text.TextUtils; +import android.util.Log; import org.dslul.openboard.inputmethod.keyboard.Keyboard; import org.dslul.openboard.inputmethod.latin.SuggestedWords.SuggestedWordInfo; @@ -294,6 +295,7 @@ public final class Suggest { final SuggestionResults suggestionResults = mDictionaryFacilitator.getSuggestionResults( wordComposer.getComposedDataSnapshot(), ngramContext, keyboard, settingsValuesForSuggestion, SESSION_ID_GESTURE, inputStyle); + // For transforming words that don't come from a dictionary, because it's our best bet final Locale locale = mDictionaryFacilitator.getLocale(); final ArrayList suggestionsContainer = diff --git a/app/src/main/res/drawable/keyboard_key_feedback_background_lxx_dark_border.xml b/app/src/main/res/drawable/keyboard_key_feedback_background_lxx_dark_border.xml index 67dad6dd2..df102e85f 100644 --- a/app/src/main/res/drawable/keyboard_key_feedback_background_lxx_dark_border.xml +++ b/app/src/main/res/drawable/keyboard_key_feedback_background_lxx_dark_border.xml @@ -5,7 +5,7 @@ android:color="#424242" /> + android:width="40dp"/> 350 - 17 - 53 - 98% - 94% + 0 + 0 + 100% + 100% - 70 + 0 - 1000 + 100 true 100 diff --git a/app/src/main/res/values/config.xml b/app/src/main/res/values/config.xml index 33bcb0603..6adfaf2da 100644 --- a/app/src/main/res/values/config.xml +++ b/app/src/main/res/values/config.xml @@ -44,8 +44,8 @@ -26.4dp 8.0dp 80dp - 50.0dp - 122dp + 45.0dp + 111dp 82% 55% 55% diff --git a/app/src/main/res/values/gesture-input.xml b/app/src/main/res/values/gesture-input.xml index 235616fbe..445a389b8 100644 --- a/app/src/main/res/values/gesture-input.xml +++ b/app/src/main/res/values/gesture-input.xml @@ -18,5 +18,5 @@ */ --> - false + true