From 18aa209ee7b2fce27290347f5f30e4d46f8e4bfa Mon Sep 17 00:00:00 2001
From: Helium314 <helium314@mailbox.org>
Date: Fri, 15 Dec 2023 14:55:41 +0100
Subject: [PATCH] revert addition of valid word cache, fixes #307

---
 .../inputmethod/latin/DictionaryFacilitatorImpl.java       | 2 +-
 .../inputmethod/latin/DictionaryFacilitatorProvider.java   | 7 +------
 2 files changed, 2 insertions(+), 7 deletions(-)

diff --git a/app/src/main/java/org/dslul/openboard/inputmethod/latin/DictionaryFacilitatorImpl.java b/app/src/main/java/org/dslul/openboard/inputmethod/latin/DictionaryFacilitatorImpl.java
index 5b4f1a5c5..c0d79430f 100644
--- a/app/src/main/java/org/dslul/openboard/inputmethod/latin/DictionaryFacilitatorImpl.java
+++ b/app/src/main/java/org/dslul/openboard/inputmethod/latin/DictionaryFacilitatorImpl.java
@@ -89,7 +89,7 @@ public class DictionaryFacilitatorImpl implements DictionaryFacilitator {
             new Class[] { Context.class, Locale.class, File.class, String.class, String.class };
 
     // todo: write cache never set, and never read (only written)
-    //  (initially was the same for the read cache, why?)
+    //  tried to use read cache for a while, but small performance improvements are not worth the work (https://github.com/Helium314/openboard/issues/307)
     private LruCache<String, Boolean> mValidSpellingWordReadCache;
     private LruCache<String, Boolean> mValidSpellingWordWriteCache;
 
diff --git a/app/src/main/java/org/dslul/openboard/inputmethod/latin/DictionaryFacilitatorProvider.java b/app/src/main/java/org/dslul/openboard/inputmethod/latin/DictionaryFacilitatorProvider.java
index a5086ddcb..718bacaee 100644
--- a/app/src/main/java/org/dslul/openboard/inputmethod/latin/DictionaryFacilitatorProvider.java
+++ b/app/src/main/java/org/dslul/openboard/inputmethod/latin/DictionaryFacilitatorProvider.java
@@ -6,16 +6,11 @@
 
 package org.dslul.openboard.inputmethod.latin;
 
-import android.util.LruCache;
-
 /**
  * Factory for instantiating DictionaryFacilitator objects.
  */
 public class DictionaryFacilitatorProvider {
     public static DictionaryFacilitator getDictionaryFacilitator(boolean isNeededForSpellChecking) {
-        final DictionaryFacilitator facilitator = new DictionaryFacilitatorImpl();
-        if (isNeededForSpellChecking)
-            facilitator.setValidSpellingWordReadCache(new LruCache<>(200));
-        return facilitator;
+        return new DictionaryFacilitatorImpl();
     }
 }