work on todos

This commit is contained in:
Helium314 2025-02-06 17:01:42 +01:00
parent d8b829f4f4
commit 2e5d8ac02b
18 changed files with 25 additions and 13 deletions

View file

@ -97,13 +97,14 @@ fun <T: Any> SearchScreen(
else onClickBack() else onClickBack()
}) { }) {
Icon( Icon(
painterResource(R.drawable.ic_arrow_left), // todo: "old" arrow icon existed, so must be somewhere in resources (maybe androidx?) painterResource(R.drawable.baseline_arrow_back_24),
stringResource(R.string.spoken_description_action_previous) stringResource(R.string.spoken_description_action_previous)
) )
} }
}, },
actions = { actions = {
IconButton(onClick = { setShowSearch(!showSearch) }) { Icon(painterResource(R.drawable.sym_keyboard_search_lxx), stringResource(R.string.label_search_key)) } IconButton(onClick = { setShowSearch(!showSearch) })
{ Icon(painterResource(R.drawable.sym_keyboard_search_lxx), stringResource(R.string.label_search_key)) }
}, },
) )
ExpandableSearchField( ExpandableSearchField(

View file

@ -17,6 +17,7 @@ import kotlinx.coroutines.flow.MutableStateFlow
// try making a dialog with reduced padding // try making a dialog with reduced padding
// work on todos in other files // work on todos in other files
// check dark and light theme (don't have dynamic) // check dark and light theme (don't have dynamic)
// any way to get rid of the "old" background on starting settings? probably comes from app theme, can we avoid it?
// rename both settingsActivities // rename both settingsActivities
// calling KeyboardSwitcher.getInstance().forceUpdateKeyboardTheme(requireContext()) while keyboard is showing shows just full screen background // calling KeyboardSwitcher.getInstance().forceUpdateKeyboardTheme(requireContext()) while keyboard is showing shows just full screen background
// but reload while keyboard is showing would be great (isn't it at least semi-done when changing one-handed mode?) // but reload while keyboard is showing would be great (isn't it at least semi-done when changing one-handed mode?)
@ -35,17 +36,11 @@ import kotlinx.coroutines.flow.MutableStateFlow
// first check whether it's really necessary (test advanced or correction screen normal and with lazyColumn) // first check whether it's really necessary (test advanced or correction screen normal and with lazyColumn)
// screens could have a lazy column of preferences and category separators, and the list has an if-setting-then-null for hiding // screens could have a lazy column of preferences and category separators, and the list has an if-setting-then-null for hiding
// lazyColumn also has a "key", this should be used and be the pref name (or maybe title because that's also for category separators) // lazyColumn also has a "key", this should be used and be the pref name (or maybe title because that's also for category separators)
// nice arrows (in top bar, and as next-screen indicator)
// PRs adding prefs -> need to do before continuing
// 1319 (soon)
// 1263 (no response for 3 weeks)
// merge main to implement all the new settings
// consider IME insets when searching
// dialogs should be rememberSaveable to survive display orientation change and stuff? // dialogs should be rememberSaveable to survive display orientation change and stuff?
// try making old fragment back stuff work better, and try the different themes (with and without top bar) // try making old fragment back stuff work better, and try the different themes (with and without top bar, it should only appear for old fragments)
// any way to get rid of the "old" background on starting settings? probably comes from app theme, can we avoid it? // PRs adding prefs -> need to do before continuing
// consider using simple list picker dialog (but the "full" one is probably better for language settings stuff) // 1263 (no response for several weeks now...)
// spdx headers everywhere // merge main to implement all the new settings
// what should be done, but not in this PR // what should be done, but not in this PR
// in general: changes to anything outside the new settings (unless necessary), and changes to how screens / fragments work // in general: changes to anything outside the new settings (unless necessary), and changes to how screens / fragments work
@ -62,6 +57,7 @@ import kotlinx.coroutines.flow.MutableStateFlow
// adjust debug settings // adjust debug settings
// have them in main screen? // have them in main screen?
// allow users to find the individual settings in search even if debug settings are not enabled? // allow users to find the individual settings in search even if debug settings are not enabled?
// replace the setup wizard
// consider disabled settings & search // consider disabled settings & search
// don't show -> users confused // don't show -> users confused

View file

@ -1,3 +1,4 @@
// SPDX-License-Identifier: GPL-3.0-only
package helium314.keyboard.settings.dialogs package helium314.keyboard.settings.dialogs
import androidx.compose.material3.Text import androidx.compose.material3.Text

View file

@ -1,3 +1,4 @@
// SPDX-License-Identifier: GPL-3.0-only
package helium314.keyboard.settings.dialogs package helium314.keyboard.settings.dialogs
import android.graphics.drawable.VectorDrawable import android.graphics.drawable.VectorDrawable

View file

@ -1,3 +1,4 @@
// SPDX-License-Identifier: GPL-3.0-only
package helium314.keyboard.settings.dialogs package helium314.keyboard.settings.dialogs
import android.widget.Toast import android.widget.Toast

View file

@ -1,3 +1,4 @@
// SPDX-License-Identifier: GPL-3.0-only
package helium314.keyboard.settings.dialogs package helium314.keyboard.settings.dialogs
import androidx.compose.material3.Text import androidx.compose.material3.Text

View file

@ -1,3 +1,4 @@
// SPDX-License-Identifier: GPL-3.0-only
package helium314.keyboard.settings.dialogs package helium314.keyboard.settings.dialogs
import androidx.compose.material3.Text import androidx.compose.material3.Text

View file

@ -1,3 +1,4 @@
// SPDX-License-Identifier: GPL-3.0-only
package helium314.keyboard.settings.dialogs package helium314.keyboard.settings.dialogs
import androidx.compose.foundation.clickable import androidx.compose.foundation.clickable

View file

@ -1,3 +1,4 @@
// SPDX-License-Identifier: GPL-3.0-only
package helium314.keyboard.settings.dialogs package helium314.keyboard.settings.dialogs
import androidx.compose.animation.core.animateDpAsState import androidx.compose.animation.core.animateDpAsState

View file

@ -1,3 +1,4 @@
// SPDX-License-Identifier: GPL-3.0-only
package helium314.keyboard.settings.dialogs package helium314.keyboard.settings.dialogs
import androidx.compose.foundation.layout.Column import androidx.compose.foundation.layout.Column

View file

@ -1,3 +1,4 @@
// SPDX-License-Identifier: GPL-3.0-only
package helium314.keyboard.settings.dialogs package helium314.keyboard.settings.dialogs
import androidx.compose.foundation.layout.fillMaxWidth import androidx.compose.foundation.layout.fillMaxWidth

View file

@ -1,3 +1,4 @@
// SPDX-License-Identifier: GPL-3.0-only
package helium314.keyboard.settings.dialogs package helium314.keyboard.settings.dialogs
import androidx.compose.foundation.layout.Row import androidx.compose.foundation.layout.Row
@ -10,7 +11,6 @@ import androidx.compose.material3.TextButton
import androidx.compose.material3.contentColorFor import androidx.compose.material3.contentColorFor
import androidx.compose.runtime.Composable import androidx.compose.runtime.Composable
import androidx.compose.runtime.CompositionLocalProvider import androidx.compose.runtime.CompositionLocalProvider
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier import androidx.compose.ui.Modifier
import androidx.compose.ui.res.stringResource import androidx.compose.ui.res.stringResource
import androidx.compose.ui.tooling.preview.Preview import androidx.compose.ui.tooling.preview.Preview

View file

@ -1,3 +1,4 @@
// SPDX-License-Identifier: GPL-3.0-only
package helium314.keyboard.settings.dialogs package helium314.keyboard.settings.dialogs
import androidx.compose.foundation.clickable import androidx.compose.foundation.clickable

View file

@ -1,3 +1,4 @@
// SPDX-License-Identifier: GPL-3.0-only
package helium314.keyboard.settings.screens package helium314.keyboard.settings.screens
import android.annotation.SuppressLint import android.annotation.SuppressLint

View file

@ -1,3 +1,4 @@
// SPDX-License-Identifier: GPL-3.0-only
package helium314.keyboard.settings.screens package helium314.keyboard.settings.screens
import androidx.compose.runtime.Composable import androidx.compose.runtime.Composable

View file

@ -1,3 +1,4 @@
// SPDX-License-Identifier: GPL-3.0-only
package helium314.keyboard.settings.screens package helium314.keyboard.settings.screens
import android.content.Context import android.content.Context

View file

@ -1,3 +1,4 @@
// SPDX-License-Identifier: GPL-3.0-only
package helium314.keyboard.settings.screens package helium314.keyboard.settings.screens
import android.content.Context import android.content.Context

View file

@ -1,3 +1,4 @@
// SPDX-License-Identifier: GPL-3.0-only
package helium314.keyboard.settings.screens package helium314.keyboard.settings.screens
import android.content.Context import android.content.Context