From 38edc6fb3ef2859de5ed5c65086247eb210af09c Mon Sep 17 00:00:00 2001 From: "Md. Rifat Hasan Jihan" <31377578+RHJihan@users.noreply.github.com> Date: Tue, 29 Aug 2023 10:52:51 +0600 Subject: [PATCH] Enabled split keyboard for landscape (#46) * Enabled split keyboard for landscape Enable split keyboard is available from medium-sized (720dp) phones (landscape). On smaller phones, this toggle will be hidden. No change on tablet layout behavior. --- .../settings/AppearanceSettingsFragment.kt | 10 +- app/src/main/res/xml-land/key_space_3kw.xml | 90 ++++++++++++++ .../res/xml-land/row_optional_number_row.xml | 33 +++++ app/src/main/res/xml-land/row_qwerty4.xml | 73 +++++++++++ app/src/main/res/xml-land/rows_azerty.xml | 116 +++++++++++++++++ .../main/res/xml-land/rows_bengali_unijoy.xml | 117 ++++++++++++++++++ app/src/main/res/xml-land/rows_qwerty.xml | 117 ++++++++++++++++++ app/src/main/res/xml-land/rows_qwertz.xml | 117 ++++++++++++++++++ .../xml-sw600dp/row_optional_number_row.xml | 33 +++++ .../main/res/xml/row_optional_number_row.xml | 16 --- 10 files changed, 703 insertions(+), 19 deletions(-) create mode 100644 app/src/main/res/xml-land/key_space_3kw.xml create mode 100644 app/src/main/res/xml-land/row_optional_number_row.xml create mode 100644 app/src/main/res/xml-land/row_qwerty4.xml create mode 100644 app/src/main/res/xml-land/rows_azerty.xml create mode 100644 app/src/main/res/xml-land/rows_bengali_unijoy.xml create mode 100644 app/src/main/res/xml-land/rows_qwerty.xml create mode 100644 app/src/main/res/xml-land/rows_qwertz.xml create mode 100644 app/src/main/res/xml-sw600dp/row_optional_number_row.xml diff --git a/app/src/main/java/org/dslul/openboard/inputmethod/latin/settings/AppearanceSettingsFragment.kt b/app/src/main/java/org/dslul/openboard/inputmethod/latin/settings/AppearanceSettingsFragment.kt index 76d38e1f..b1d9ac7d 100644 --- a/app/src/main/java/org/dslul/openboard/inputmethod/latin/settings/AppearanceSettingsFragment.kt +++ b/app/src/main/java/org/dslul/openboard/inputmethod/latin/settings/AppearanceSettingsFragment.kt @@ -29,8 +29,9 @@ import androidx.core.content.edit import org.dslul.openboard.inputmethod.keyboard.KeyboardSwitcher import org.dslul.openboard.inputmethod.keyboard.KeyboardTheme import org.dslul.openboard.inputmethod.latin.R -import org.dslul.openboard.inputmethod.latin.common.Constants import org.dslul.openboard.inputmethod.latin.define.ProductionFlags +import java.lang.Float.max +import java.lang.Float.min import java.util.* /** @@ -88,10 +89,13 @@ class AppearanceSettingsFragment : SubScreenFragment(), Preference.OnPreferenceC } setupTheme() - if (!ProductionFlags.IS_SPLIT_KEYBOARD_SUPPORTED || - Constants.isPhone(Settings.readScreenMetrics(resources))) { + + val widthDp = activity.resources.displayMetrics.widthPixels / activity.resources.displayMetrics.density + val heightDp = activity.resources.displayMetrics.heightPixels / activity.resources.displayMetrics.density + if (!ProductionFlags.IS_SPLIT_KEYBOARD_SUPPORTED || (min(widthDp, heightDp) < 600 && max(widthDp, heightDp) < 720)) { removePreference(Settings.PREF_ENABLE_SPLIT_KEYBOARD) } + setupKeyboardHeight( Settings.PREF_KEYBOARD_HEIGHT_SCALE, SettingsValues.DEFAULT_SIZE_SCALE) } diff --git a/app/src/main/res/xml-land/key_space_3kw.xml b/app/src/main/res/xml-land/key_space_3kw.xml new file mode 100644 index 00000000..eaf63bb2 --- /dev/null +++ b/app/src/main/res/xml-land/key_space_3kw.xml @@ -0,0 +1,90 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/app/src/main/res/xml-land/row_optional_number_row.xml b/app/src/main/res/xml-land/row_optional_number_row.xml new file mode 100644 index 00000000..0da298bf --- /dev/null +++ b/app/src/main/res/xml-land/row_optional_number_row.xml @@ -0,0 +1,33 @@ + + + + + + + + + + + + + + + + + + \ No newline at end of file diff --git a/app/src/main/res/xml-land/row_qwerty4.xml b/app/src/main/res/xml-land/row_qwerty4.xml new file mode 100644 index 00000000..6cc2486b --- /dev/null +++ b/app/src/main/res/xml-land/row_qwerty4.xml @@ -0,0 +1,73 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/app/src/main/res/xml-land/rows_azerty.xml b/app/src/main/res/xml-land/rows_azerty.xml new file mode 100644 index 00000000..72157eae --- /dev/null +++ b/app/src/main/res/xml-land/rows_azerty.xml @@ -0,0 +1,116 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/app/src/main/res/xml-land/rows_bengali_unijoy.xml b/app/src/main/res/xml-land/rows_bengali_unijoy.xml new file mode 100644 index 00000000..be20beb2 --- /dev/null +++ b/app/src/main/res/xml-land/rows_bengali_unijoy.xml @@ -0,0 +1,117 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/app/src/main/res/xml-land/rows_qwerty.xml b/app/src/main/res/xml-land/rows_qwerty.xml new file mode 100644 index 00000000..66232e0c --- /dev/null +++ b/app/src/main/res/xml-land/rows_qwerty.xml @@ -0,0 +1,117 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/app/src/main/res/xml-land/rows_qwertz.xml b/app/src/main/res/xml-land/rows_qwertz.xml new file mode 100644 index 00000000..db16806d --- /dev/null +++ b/app/src/main/res/xml-land/rows_qwertz.xml @@ -0,0 +1,117 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/app/src/main/res/xml-sw600dp/row_optional_number_row.xml b/app/src/main/res/xml-sw600dp/row_optional_number_row.xml new file mode 100644 index 00000000..0da298bf --- /dev/null +++ b/app/src/main/res/xml-sw600dp/row_optional_number_row.xml @@ -0,0 +1,33 @@ + + + + + + + + + + + + + + + + + + \ No newline at end of file diff --git a/app/src/main/res/xml/row_optional_number_row.xml b/app/src/main/res/xml/row_optional_number_row.xml index 0da298bf..f9748ed0 100644 --- a/app/src/main/res/xml/row_optional_number_row.xml +++ b/app/src/main/res/xml/row_optional_number_row.xml @@ -5,22 +5,6 @@ - - - - - - -