From 7eaba95f011b514adbe9bb91f46d51a49bc7a0c0 Mon Sep 17 00:00:00 2001
From: Helium314 <helium314@mailbox.org>
Date: Mon, 4 Sep 2023 16:28:18 +0200
Subject: [PATCH] address some warnings, remove "state_has_morekeys" drawabled
 from holo key popup

---
 .../inputmethod/keyboard/internal/KeyPreviewView.java       | 5 +++--
 .../org/dslul/openboard/inputmethod/latin/InputView.java    | 1 +
 .../main/res/drawable/keyboard_key_feedback_holo_white.xml  | 6 ------
 3 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/app/src/main/java/org/dslul/openboard/inputmethod/keyboard/internal/KeyPreviewView.java b/app/src/main/java/org/dslul/openboard/inputmethod/keyboard/internal/KeyPreviewView.java
index e73f51ca4..c3c9c1d01 100644
--- a/app/src/main/java/org/dslul/openboard/inputmethod/keyboard/internal/KeyPreviewView.java
+++ b/app/src/main/java/org/dslul/openboard/inputmethod/keyboard/internal/KeyPreviewView.java
@@ -24,7 +24,8 @@ import android.text.TextUtils;
 import android.util.AttributeSet;
 import android.util.TypedValue;
 import android.view.Gravity;
-import android.widget.TextView;
+
+import androidx.appcompat.widget.AppCompatTextView;
 
 import org.dslul.openboard.inputmethod.keyboard.Key;
 import org.dslul.openboard.inputmethod.latin.R;
@@ -34,7 +35,7 @@ import java.util.HashSet;
 /**
  * The pop up key preview view.
  */
-public class KeyPreviewView extends TextView {
+public class KeyPreviewView extends AppCompatTextView {
     public static final int POSITION_MIDDLE = 0;
     public static final int POSITION_LEFT = 1;
     public static final int POSITION_RIGHT = 2;
diff --git a/app/src/main/java/org/dslul/openboard/inputmethod/latin/InputView.java b/app/src/main/java/org/dslul/openboard/inputmethod/latin/InputView.java
index 368c38cf1..bff98d70f 100644
--- a/app/src/main/java/org/dslul/openboard/inputmethod/latin/InputView.java
+++ b/app/src/main/java/org/dslul/openboard/inputmethod/latin/InputView.java
@@ -41,6 +41,7 @@ public final class InputView extends FrameLayout {
 
     @Override
     protected void onFinishInflate() {
+        super.onFinishInflate();
         final SuggestionStripView suggestionStripView =
                 findViewById(R.id.suggestion_strip_view);
         mMainKeyboardView = findViewById(R.id.keyboard_view);
diff --git a/app/src/main/res/drawable/keyboard_key_feedback_holo_white.xml b/app/src/main/res/drawable/keyboard_key_feedback_holo_white.xml
index bd197071b..eaea1769f 100644
--- a/app/src/main/res/drawable/keyboard_key_feedback_holo_white.xml
+++ b/app/src/main/res/drawable/keyboard_key_feedback_holo_white.xml
@@ -19,18 +19,12 @@
     xmlns:latin="http://schemas.android.com/apk/res-auto"
 >
     <!-- Left edge -->
-    <item latin:state_left_edge="true" latin:state_has_morekeys="true"
-          android:drawable="@drawable/keyboard_key_feedback_left_more_background_klp" />
     <item latin:state_left_edge="true"
           android:drawable="@drawable/keyboard_key_feedback_left_background_klp" />
 
     <!-- Right edge -->
-    <item latin:state_right_edge="true" latin:state_has_morekeys="true"
-          android:drawable="@drawable/keyboard_key_feedback_right_more_background_klp" />
     <item latin:state_right_edge="true"
           android:drawable="@drawable/keyboard_key_feedback_right_background_klp" />
 
-    <item latin:state_has_morekeys="true"
-          android:drawable="@drawable/keyboard_key_feedback_more_background_klp" />
     <item android:drawable="@drawable/keyboard_key_feedback_background_klp" />
 </selector>