luckyimnotanigger/HeliBoard
1
0
Fork 0
mirror of https://github.com/Helium314/HeliBoard.git synced 2025-06-24 10:00:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix missing auto-space with url detection

Browse source 
caused by bug in nonWordCodePointAndNoSpaceBeforeCursor
fixes #229
This commit is contained in:
Helium314 2023-10-21 08:29:47 +02:00
parent d47386c745
commit 9975a7d8f6
2 changed files with 16 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
app/src/main/java/org/dslul/openboard/inputmethod/latin/common/StringUtils.kt
View file

@ -34,9 +34,9 @@ fun nonWordCodePointAndNoSpaceBeforeCursor(s: CharSequence, spacingAndPunctuatio
space = true
if (!nonWordCodePoint && !spacingAndPunctuations.isWordCodePoint(it))
nonWordCodePoint = true
space && nonWordCodePoint
space && nonWordCodePoint // stop if both are found
}
return space && nonWordCodePoint
return nonWordCodePoint && !space // return true if an non-word codepoint and no space was found
}
fun hasLetterBeforeLastSpaceBeforeCursor(s: CharSequence): Boolean {

14
app/src/test/java/org/dslul/openboard/inputmethod/latin/InputLogicTest.kt
View file

@ -463,6 +463,20 @@ class InputLogicTest {
assertEquals("b", composingText)
}
@Test fun `autospace works in URL field when input isn't URL, also for multiple suggestions`() {
reset()
DeviceProtectedUtils.getSharedPreferences(latinIME).edit { putBoolean(Settings.PREF_URL_DETECTION, true) }
setInputType(InputType.TYPE_CLASS_TEXT or InputType.TYPE_TEXT_VARIATION_URI)
pickSuggestion("this")
pickSuggestion("is")
assertEquals("this is", text)
pickSuggestion("not")
assertEquals("this is not", text)
input('c')
assertEquals("this is not c", text)
assertEquals("c", composingText)
}
@Test fun `emoji is added to dictionary`() {
// check both text and codepoint input
reset()