luckyimnotanigger/HeliBoard
1
0
Fork 0
mirror of https://github.com/Helium314/HeliBoard.git synced 2025-06-19 07:30:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix issue that could result in autospace being added before period

Browse source
This commit is contained in:
Helium314 2025-03-26 18:29:57 +01:00
parent b600431af9
commit c0b14635fd
2 changed files with 4 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

4
app/src/main/java/helium314/keyboard/latin/inputlogic/InputLogic.java
View file

@ -949,7 +949,9 @@ public final class InputLogic {
// TODO: remove isWordConnector() and use isUsuallyFollowedBySpace() instead. // TODO: remove isWordConnector() and use isUsuallyFollowedBySpace() instead.
// See onStartBatchInput() to see how to do it. // See onStartBatchInput() to see how to do it.
if (SpaceState.PHANTOM == inputTransaction.getMSpaceState() if (SpaceState.PHANTOM == inputTransaction.getMSpaceState()
&& !settingsValues.isWordConnector(codePoint)) { && !settingsValues.isWordConnector(codePoint)
&& !settingsValues.isUsuallyFollowedBySpace(codePoint) // only relevant in rare cases
) {
if (isComposingWord) { if (isComposingWord) {
// Sanity check // Sanity check
throw new RuntimeException("Should not be composing here"); throw new RuntimeException("Should not be composing here");

7
app/src/test/java/helium314/keyboard/latin/InputLogicTest.kt
View file

@ -203,13 +203,7 @@ class InputLogicTest {
assertEquals("example.net", composingText) assertEquals("example.net", composingText)
} }
// fails because
// period is not handled with handleSeparatorEvent in this case
// pickSuggestion sets phantom space state
// insertAutomaticSpaceIfOptionsAndTextAllow allows the space
// todo: fix it either in some of those functions, or by finally improving URL detection in a reasonable (and performant) way
@Test fun noAutospaceInUrlFieldWhenPickingSuggestion() { @Test fun noAutospaceInUrlFieldWhenPickingSuggestion() {
if (BuildConfig.BUILD_TYPE == "runTests") return
reset() reset()
setInputType(InputType.TYPE_CLASS_TEXT or InputType.TYPE_TEXT_VARIATION_URI) setInputType(InputType.TYPE_CLASS_TEXT or InputType.TYPE_TEXT_VARIATION_URI)
chainInput("exam") chainInput("exam")
@ -262,6 +256,7 @@ class InputLogicTest {
reset() reset()
latinIME.prefs().edit { putBoolean(Settings.PREF_URL_DETECTION, true) } latinIME.prefs().edit { putBoolean(Settings.PREF_URL_DETECTION, true) }
latinIME.prefs().edit { putBoolean(Settings.PREF_AUTOSPACE_AFTER_PUNCTUATION, true) } latinIME.prefs().edit { putBoolean(Settings.PREF_AUTOSPACE_AFTER_PUNCTUATION, true) }
latinIME.prefs().edit { putBoolean(Settings.PREF_SHIFT_REMOVES_AUTOSPACE, true) }
input("bla") input("bla")
input('.') input('.')
functionalKeyPress(KeyCode.SHIFT) // should remove the phantom space (in addition to normal effect) functionalKeyPress(KeyCode.SHIFT) // should remove the phantom space (in addition to normal effect)