luckyimnotanigger/HeliBoard
1
0
Fork 0
mirror of https://github.com/Helium314/HeliBoard.git synced 2025-05-14 14:02:44 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix settings not being applied on change (and find a new issue...)

Browse source
This commit is contained in:
Helium314 2025-02-05 16:29:26 +01:00
parent 4eadaa8965
commit ca89eaa51c
2 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
app/src/main/java/helium314/keyboard/latin/LatinIME.java
View file

@ -880,8 +880,6 @@ public class LatinIME extends InputMethodService implements
void onStartInputInternal(final EditorInfo editorInfo, final boolean restarting) { void onStartInputInternal(final EditorInfo editorInfo, final boolean restarting) {
super.onStartInput(editorInfo, restarting); super.onStartInput(editorInfo, restarting);
reloadIfNecessary();
final List<Locale> hintLocales = EditorInfoCompatUtils.getHintLocales(editorInfo); final List<Locale> hintLocales = EditorInfoCompatUtils.getHintLocales(editorInfo);
if (hintLocales == null) { if (hintLocales == null) {
return; return;
@ -903,6 +901,8 @@ public class LatinIME extends InputMethodService implements
void onStartInputViewInternal(final EditorInfo editorInfo, final boolean restarting) { void onStartInputViewInternal(final EditorInfo editorInfo, final boolean restarting) {
super.onStartInputView(editorInfo, restarting); super.onStartInputView(editorInfo, restarting);
reloadIfNecessary();
mDictionaryFacilitator.onStartInput(); mDictionaryFacilitator.onStartInput();
// Switch to the null consumer to handle cases leading to early exit below, for which we // Switch to the null consumer to handle cases leading to early exit below, for which we
// also wouldn't be consuming gesture data. // also wouldn't be consuming gesture data.

2
app/src/main/java/helium314/keyboard/settings/SettingsActivity.kt
View file

@ -17,7 +17,6 @@ import kotlinx.coroutines.flow.MutableStateFlow
// make all prefs actually work // make all prefs actually work
// appearance // appearance
// click on bg image does nothing when already set (but works after reload) // click on bg image does nothing when already set (but works after reload)
// narrow key gaps setting is not changing properly?
// custom font loading not implemented // custom font loading not implemented
// have large bg image, and first-time load the keyboard on new search field -> bg image expands full size // have large bg image, and first-time load the keyboard on new search field -> bg image expands full size
// advanced // advanced
@ -32,6 +31,7 @@ import kotlinx.coroutines.flow.MutableStateFlow
// check dark and light theme (don't have dynamic) // check dark and light theme (don't have dynamic)
// rename both settingsActivities // rename both settingsActivities
// work on todos in other files // work on todos in other files
// calling KeyboardSwitcher.getInstance().forceUpdateKeyboardTheme(requireContext()) while keyboard is showing shows just full screen background
// use better / more structured and clear names and arrangement of files // use better / more structured and clear names and arrangement of files
// the prefDef and AllPrefs, also be clear about pref <-> key <-> prefKey (all used, probably should be latter) // the prefDef and AllPrefs, also be clear about pref <-> key <-> prefKey (all used, probably should be latter)
// there is a lot more ambiguous naming... // there is a lot more ambiguous naming...