update comments

This commit is contained in:
Helium314 2023-09-04 08:52:50 +02:00
parent fe51ee5f98
commit d9d1204647
6 changed files with 13 additions and 3 deletions

View file

@ -4,6 +4,7 @@ about: Create a report to help us improve
labels: bug labels: bug
--- ---
<!-- Please search open and closed issues to avoid duplicates -->
**Does it happen in OpenBoard, or is it exclusive to this modified version?** **Does it happen in OpenBoard, or is it exclusive to this modified version?**
**Describe the bug** **Describe the bug**

View file

@ -5,6 +5,7 @@ labels: enhancement
--- ---
<!-- <!--
Please search open and closed issues to avoid duplicates.
Note that this version of OpenBoard is focusing only on a few things. You can add a feature request, but at the current stage it's unlikely it will get implemented. Note that this version of OpenBoard is focusing only on a few things. You can add a feature request, but at the current stage it's unlikely it will get implemented.
--> -->

View file

@ -5,6 +5,8 @@ labels: dictionaries
--- ---
<!-- <!--
Please search open and closed issues to avoid duplicates.
Before you suggest adding a language, check if the language is already included in the downloadable dictionaries at https://github.com/Helium314/openboard/tree/new/dictionaries/dict or experimental dictionaries at https://github.com/Helium314/openboard/tree/new/dictionaries/experimental/dict Before you suggest adding a language, check if the language is already included in the downloadable dictionaries at https://github.com/Helium314/openboard/tree/new/dictionaries/dict or experimental dictionaries at https://github.com/Helium314/openboard/tree/new/dictionaries/experimental/dict
If you open an issue about an existing dictionary, add information which dictionary you use (included in app, or link) If you open an issue about an existing dictionary, add information which dictionary you use (included in app, or link)

View file

@ -4,6 +4,8 @@ about: Anything that does not fit into the other categories
--- ---
<!-- <!--
Please search open and closed issues to avoid duplicates.
Note that this version of OpenBoard is focusing only on a few things. You can add a feature request or open other issues, but at the current stage it could take a long time until things are improved or even until you get a response. Note that this version of OpenBoard is focusing only on a few things. You can add a feature request or open other issues, but at the current stage it could take a long time until things are improved or even until you get a response.
If you add screenshots, please reduce the size or use thumbnails to keep the issue nicely readable. If you add screenshots, please reduce the size or use thumbnails to keep the issue nicely readable.

View file

@ -69,7 +69,7 @@ class ClipboardAdapter(
} }
clipboardLayoutParams.setItemProperties(view) clipboardLayoutParams.setItemProperties(view)
val colors = Settings.getInstance().current.mColors val colors = Settings.getInstance().current.mColors
if (colors is HoloColors) if (colors is HoloColors) // todo: this logic should be in Colors, not here
pinnedIconView.colorFilter = colors.accentColorFilter pinnedIconView.colorFilter = colors.accentColorFilter
} }

View file

@ -5,7 +5,6 @@ import android.graphics.Color;
import android.graphics.ColorFilter; import android.graphics.ColorFilter;
import android.graphics.PorterDuff; import android.graphics.PorterDuff;
import android.graphics.drawable.Drawable; import android.graphics.drawable.Drawable;
import android.util.Log;
import androidx.annotation.Nullable; import androidx.annotation.Nullable;
import androidx.core.graphics.BlendModeColorFilterCompat; import androidx.core.graphics.BlendModeColorFilterCompat;
@ -108,10 +107,15 @@ public class Colors {
final int[][] states = new int[][] { final int[][] states = new int[][] {
// are other states used? // are other states used?
// looks like only microphone ("shortcut") key can ever be disabled, but then it's not shown anyway... // looks like only microphone ("shortcut") key can ever be disabled, but then it's not shown anyway...
// and checked seems unused // checkable/checked is only used for sticky shift key in old holo theme, but drawables not used in new version
// active is used for action key
// empty is used for emoji and spacers
new int[] { android.R.attr.state_pressed}, // pressed new int[] { android.R.attr.state_pressed}, // pressed
new int[] { -android.R.attr.state_pressed}, // not pressed new int[] { -android.R.attr.state_pressed}, // not pressed
}; };
// todo (idea): make better use of the states?
// could also use / create StateListDrawables in colors (though that's a style than a color...)
// this would better allow choosing e.g. cornered/rounded drawables for moreKeys or moreSuggestions
backgroundFilter = BlendModeColorFilterCompat.createBlendModeColorFilterCompat(background, BlendModeCompat.MODULATE); backgroundFilter = BlendModeColorFilterCompat.createBlendModeColorFilterCompat(background, BlendModeCompat.MODULATE);
adjustedKeyText = brightenOrDarken(keyText, true); adjustedKeyText = brightenOrDarken(keyText, true);