From e36a20719f2eaf994775ff7cdbb51aa15e738a29 Mon Sep 17 00:00:00 2001
From: Helium314 <helium314@mailbox.org>
Date: Sun, 9 Feb 2025 19:08:17 +0100
Subject: [PATCH] remove todos (was already mostly solved)

---
 .../helium314/keyboard/settings/dialogs/TextInputDialog.kt     | 1 +
 .../java/helium314/keyboard/settings/screens/AdvancedScreen.kt | 3 ++-
 .../helium314/keyboard/settings/screens/AppearanceScreen.kt    | 2 +-
 3 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/app/src/main/java/helium314/keyboard/settings/dialogs/TextInputDialog.kt b/app/src/main/java/helium314/keyboard/settings/dialogs/TextInputDialog.kt
index bfd68b9bb..384799cc9 100644
--- a/app/src/main/java/helium314/keyboard/settings/dialogs/TextInputDialog.kt
+++ b/app/src/main/java/helium314/keyboard/settings/dialogs/TextInputDialog.kt
@@ -65,6 +65,7 @@ fun TextInputDialog(
         modifier = modifier,
         title = title,
         text = {
+            // todo: this sometimes looks weird on start (like non-outlined field where the label is in the text field)
             OutlinedTextField(
                 value = value,
                 onValueChange = { value = it },
diff --git a/app/src/main/java/helium314/keyboard/settings/screens/AdvancedScreen.kt b/app/src/main/java/helium314/keyboard/settings/screens/AdvancedScreen.kt
index 96e8b74cc..d33d4d0cc 100644
--- a/app/src/main/java/helium314/keyboard/settings/screens/AdvancedScreen.kt
+++ b/app/src/main/java/helium314/keyboard/settings/screens/AdvancedScreen.kt
@@ -11,6 +11,7 @@ import androidx.compose.runtime.Composable
 import androidx.compose.runtime.getValue
 import androidx.compose.runtime.mutableStateOf
 import androidx.compose.runtime.remember
+import androidx.compose.runtime.saveable.rememberSaveable
 import androidx.compose.runtime.setValue
 import androidx.compose.ui.Modifier
 import androidx.compose.ui.draw.scale
@@ -167,7 +168,7 @@ fun createAdvancedSettings(context: Context) = listOf(
         SwitchPreference(it, Defaults.PREF_ABC_AFTER_EMOJI)
     },
     Setting(context, Settings.PREF_CUSTOM_CURRENCY_KEY, R.string.customize_currencies) { setting ->
-        var showDialog by remember { mutableStateOf(false) } // todo: textInputDialog...
+        var showDialog by rememberSaveable { mutableStateOf(false) }
         Preference(
             name = setting.title,
             onClick = { showDialog = true }
diff --git a/app/src/main/java/helium314/keyboard/settings/screens/AppearanceScreen.kt b/app/src/main/java/helium314/keyboard/settings/screens/AppearanceScreen.kt
index f41e51257..c28cd5397 100644
--- a/app/src/main/java/helium314/keyboard/settings/screens/AppearanceScreen.kt
+++ b/app/src/main/java/helium314/keyboard/settings/screens/AppearanceScreen.kt
@@ -283,7 +283,7 @@ fun createAppearanceSettings(context: Context) = listOf(
         ) { keyboardNeedsReload = true }
     },
     Setting(context, Settings.PREF_SPACE_BAR_TEXT, R.string.prefs_space_bar_text) { setting ->
-        var showDialog by rememberSaveable { mutableStateOf(false) } // todo: textInputDialog...
+        var showDialog by rememberSaveable { mutableStateOf(false) }
         val prefs = LocalContext.current.prefs()
         Preference(
             name = setting.title,