From a5c45318a7a88e5a5c461a623116c2dcd26453c1 Mon Sep 17 00:00:00 2001 From: Helium314 Date: Wed, 9 Mar 2022 09:42:24 +0100 Subject: [PATCH 1/2] Show suggestions everywhere except in password fields --- .../dslul/openboard/inputmethod/latin/InputAttributes.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/org/dslul/openboard/inputmethod/latin/InputAttributes.java b/app/src/main/java/org/dslul/openboard/inputmethod/latin/InputAttributes.java index 815a7fe6a..ee82915ad 100644 --- a/app/src/main/java/org/dslul/openboard/inputmethod/latin/InputAttributes.java +++ b/app/src/main/java/org/dslul/openboard/inputmethod/latin/InputAttributes.java @@ -105,12 +105,12 @@ public final class InputAttributes { // TODO: Have a helper method in InputTypeUtils // Make sure that passwords are not displayed in {@link SuggestionStripView}. - final boolean shouldSuppressSuggestions = mIsPasswordField + final boolean shouldSuppressSuggestions = mIsPasswordField; //|| InputTypeUtils.isEmailVariation(variation) //|| InputType.TYPE_TEXT_VARIATION_URI == variation //|| InputType.TYPE_TEXT_VARIATION_FILTER == variation //|| flagNoSuggestions - || flagAutoComplete; + //|| flagAutoComplete; mShouldShowSuggestions = !shouldSuppressSuggestions; mShouldInsertSpacesAutomatically = InputTypeUtils.isAutoSpaceFriendlyType(inputType); From 66967eb2a1efd26cf4c8b6f06e37803f8e139789 Mon Sep 17 00:00:00 2001 From: Helium314 Date: Thu, 10 Mar 2022 18:51:08 +0100 Subject: [PATCH 2/2] simplify setting mShouldShowSuggestions, heed flagNoSuggestions --- .../openboard/inputmethod/latin/InputAttributes.java | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/app/src/main/java/org/dslul/openboard/inputmethod/latin/InputAttributes.java b/app/src/main/java/org/dslul/openboard/inputmethod/latin/InputAttributes.java index ee82915ad..e36a90388 100644 --- a/app/src/main/java/org/dslul/openboard/inputmethod/latin/InputAttributes.java +++ b/app/src/main/java/org/dslul/openboard/inputmethod/latin/InputAttributes.java @@ -105,13 +105,7 @@ public final class InputAttributes { // TODO: Have a helper method in InputTypeUtils // Make sure that passwords are not displayed in {@link SuggestionStripView}. - final boolean shouldSuppressSuggestions = mIsPasswordField; - //|| InputTypeUtils.isEmailVariation(variation) - //|| InputType.TYPE_TEXT_VARIATION_URI == variation - //|| InputType.TYPE_TEXT_VARIATION_FILTER == variation - //|| flagNoSuggestions - //|| flagAutoComplete; - mShouldShowSuggestions = !shouldSuppressSuggestions; + mShouldShowSuggestions = !(mIsPasswordField || flagNoSuggestions); mShouldInsertSpacesAutomatically = InputTypeUtils.isAutoSpaceFriendlyType(inputType);