luckyimnotanigger/HeliBoard
1
0
Fork 0
mirror of https://github.com/Helium314/HeliBoard.git synced 2025-04-19 21:59:11 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

allow enabling popups on keypress on tablets

Browse source 
still disabled by default, because the popups are too small (size should not be in dp, but in % of screen width or something like that)
fixes #799
This commit is contained in:
Helium314 2024-05-19 15:26:57 +02:00
parent 77f03b0756
commit f81e24d550
7 changed files with 2 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
README.md
View file

@ -147,7 +147,7 @@ __Planned features and improvements:__
__What will _not_ be added:__ __What will _not_ be added:__
* Material 3 (not worth adding 1.5 MB to app size) * Material 3 (not worth adding 1.5 MB to app size)
* Dictionaries for more languages (you can still download them) * Dictionaries for more languages (you can still download them)
* Anything that requires additional permissions * Anything that requires additional permissions, unless there is a very good reason
# License # License

3
app/src/main/java/helium314/keyboard/latin/settings/PreferencesSettingsFragment.java
View file

@ -49,9 +49,6 @@ public final class PreferencesSettingsFragment extends SubScreenFragment {
removePreference(Settings.PREF_VIBRATE_ON); removePreference(Settings.PREF_VIBRATE_ON);
removePreference(Settings.PREF_VIBRATION_DURATION_SETTINGS); removePreference(Settings.PREF_VIBRATION_DURATION_SETTINGS);
} }
if (!Settings.readFromBuildConfigIfToShowKeyPreviewPopupOption(res)) {
removePreference(Settings.PREF_POPUP_ON);
}
setupKeypressVibrationDurationSettings(); setupKeypressVibrationDurationSettings();
setupKeypressSoundVolumeSettings(); setupKeypressSoundVolumeSettings();

10
app/src/main/java/helium314/keyboard/latin/settings/Settings.java
View file

@ -303,16 +303,8 @@ public final class Settings implements SharedPreferences.OnSharedPreferenceChang
return JniUtils.sHaveGestureLib && prefs.getBoolean(PREF_GESTURE_INPUT, true); return JniUtils.sHaveGestureLib && prefs.getBoolean(PREF_GESTURE_INPUT, true);
} }
public static boolean readFromBuildConfigIfToShowKeyPreviewPopupOption(final Resources res) {
return res.getBoolean(R.bool.config_enable_show_key_preview_popup_option);
}
public static boolean readKeyPreviewPopupEnabled(final SharedPreferences prefs, final Resources res) { public static boolean readKeyPreviewPopupEnabled(final SharedPreferences prefs, final Resources res) {
final boolean defaultKeyPreviewPopup = res.getBoolean( final boolean defaultKeyPreviewPopup = res.getBoolean(R.bool.config_default_key_preview_popup);
R.bool.config_default_key_preview_popup);
if (!readFromBuildConfigIfToShowKeyPreviewPopupOption(res)) {
return defaultKeyPreviewPopup;
}
return prefs.getBoolean(PREF_POPUP_ON, defaultKeyPreviewPopup); return prefs.getBoolean(PREF_POPUP_ON, defaultKeyPreviewPopup);
} }

1
app/src/main/res/values-sw430dp/config-per-form-factor.xml
View file

@ -7,7 +7,6 @@
<!-- Configuration values for Large Phone. --> <!-- Configuration values for Large Phone. -->
<resources> <resources>
<bool name="config_enable_show_key_preview_popup_option">true</bool>
<!-- Whether or not Popup on key press is enabled by default --> <!-- Whether or not Popup on key press is enabled by default -->
<bool name="config_default_key_preview_popup">true</bool> <bool name="config_default_key_preview_popup">true</bool>
<bool name="config_default_sound_enabled">false</bool> <bool name="config_default_sound_enabled">false</bool>

1
app/src/main/res/values-sw600dp/config-per-form-factor.xml
View file

@ -7,7 +7,6 @@
<!-- Configuration values for Small Tablet. --> <!-- Configuration values for Small Tablet. -->
<resources> <resources>
<bool name="config_enable_show_key_preview_popup_option">false</bool>
<!-- Whether or not Popup on key press is enabled by default --> <!-- Whether or not Popup on key press is enabled by default -->
<bool name="config_default_key_preview_popup">false</bool> <bool name="config_default_key_preview_popup">false</bool>
<bool name="config_default_sound_enabled">false</bool> <bool name="config_default_sound_enabled">false</bool>

1
app/src/main/res/values-sw768dp/config-per-form-factor.xml
View file

@ -7,7 +7,6 @@
<!-- Configuration values for Large Tablet. --> <!-- Configuration values for Large Tablet. -->
<resources> <resources>
<bool name="config_enable_show_key_preview_popup_option">false</bool>
<!-- Whether or not Popup on key press is enabled by default --> <!-- Whether or not Popup on key press is enabled by default -->
<bool name="config_default_key_preview_popup">false</bool> <bool name="config_default_key_preview_popup">false</bool>
<bool name="config_default_sound_enabled">false</bool> <bool name="config_default_sound_enabled">false</bool>

1
app/src/main/res/values/config-per-form-factor.xml
View file

@ -7,7 +7,6 @@
<!-- Configuration values for Small Phone. --> <!-- Configuration values for Small Phone. -->
<resources> <resources>
<bool name="config_enable_show_key_preview_popup_option">true</bool>
<!-- Whether or not Popup on key press is enabled by default --> <!-- Whether or not Popup on key press is enabled by default -->
<bool name="config_default_key_preview_popup">true</bool> <bool name="config_default_key_preview_popup">true</bool>
<bool name="config_default_sound_enabled">false</bool> <bool name="config_default_sound_enabled">false</bool>