From ff7406fb9835f23d0567a5c460c3a09411497927 Mon Sep 17 00:00:00 2001 From: Trevor Terris Date: Mon, 22 Nov 2021 06:36:16 -0500 Subject: [PATCH] Show suggestion strip on password input when paste enabled --- .../java/org/dslul/openboard/inputmethod/latin/LatinIME.java | 3 ++- .../inputmethod/latin/suggestions/SuggestionStripView.java | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/org/dslul/openboard/inputmethod/latin/LatinIME.java b/app/src/main/java/org/dslul/openboard/inputmethod/latin/LatinIME.java index c478573ed..d789d58ca 100644 --- a/app/src/main/java/org/dslul/openboard/inputmethod/latin/LatinIME.java +++ b/app/src/main/java/org/dslul/openboard/inputmethod/latin/LatinIME.java @@ -1588,10 +1588,11 @@ public class LatinIME extends InputMethodService implements KeyboardActionListen currentSettingsValues.mInputAttributes.mShouldShowSuggestions && currentSettingsValues.isSuggestionsEnabledPerUserSettings(); final boolean shouldShowSuggestionsStripUnlessPassword = currentSettingsValues.mShowsVoiceInputKey + || currentSettingsValues.mShowsPasteKey || shouldShowSuggestionCandidates || currentSettingsValues.isApplicationSpecifiedCompletionsOn(); final boolean shouldShowSuggestionsStrip = shouldShowSuggestionsStripUnlessPassword - && !currentSettingsValues.mInputAttributes.mIsPasswordField; + && (!currentSettingsValues.mInputAttributes.mIsPasswordField || currentSettingsValues.mShowsPasteKey); mSuggestionStripView.updateVisibility(shouldShowSuggestionsStrip, isFullscreenMode()); if (!shouldShowSuggestionsStrip) { return; diff --git a/app/src/main/java/org/dslul/openboard/inputmethod/latin/suggestions/SuggestionStripView.java b/app/src/main/java/org/dslul/openboard/inputmethod/latin/suggestions/SuggestionStripView.java index 58d21bf1e..c636b0af0 100644 --- a/app/src/main/java/org/dslul/openboard/inputmethod/latin/suggestions/SuggestionStripView.java +++ b/app/src/main/java/org/dslul/openboard/inputmethod/latin/suggestions/SuggestionStripView.java @@ -443,7 +443,8 @@ public final class SuggestionStripView extends RelativeLayout implements OnClick } if (view == mPasteKey) { CharSequence selectionSequence = mListener.getSelection(); - if (selectionSequence != null && selectionSequence.length() > 0) { + if (selectionSequence != null && selectionSequence.length() > 0 + && !Settings.getInstance().getCurrent().mInputAttributes.mIsPasswordField) { ClipboardManager clipboardManager = (ClipboardManager) getContext().getSystemService(Context.CLIPBOARD_SERVICE); clipboardManager.setPrimaryClip(ClipData.newPlainText(selectionSequence, selectionSequence)); }