Bug fixes

This commit is contained in:
Juan Gilsanz Polo 2023-11-02 18:26:58 +01:00
parent 0e6cde57f0
commit e5a971f3a3
6 changed files with 273 additions and 274 deletions

View file

@ -214,7 +214,7 @@ class _MainState extends State<Main> with WidgetsBindingObserver {
isBeta: appConfigProvider.getAppInfo!.version.contains('beta'), isBeta: appConfigProvider.getAppInfo!.version.contains('beta'),
); );
if (result != null && appConfigProvider.doNotRememberVersion != result.tagName && mounted) { if (result != null && appConfigProvider.doNotRememberVersion != result.tagName && mounted) {
await showDialog( showDialog(
context: context, context: context,
builder: (context) => UpdateModal( builder: (context) => UpdateModal(
gitHubRelease: result, gitHubRelease: result,

View file

@ -188,7 +188,6 @@ class _AddedListState extends State<AddedList> {
: null, : null,
onDelete: openDeleteModal, onDelete: openDeleteModal,
splitView: widget.splitView, splitView: widget.splitView,
serverVersion: statusProvider.serverStatus!.serverVersion,
), ),
noData: SizedBox( noData: SizedBox(
width: double.maxFinite, width: double.maxFinite,

View file

@ -5,6 +5,7 @@ import 'package:flutter_gen/gen_l10n/app_localizations.dart';
import 'package:adguard_home_manager/widgets/custom_list_tile.dart'; import 'package:adguard_home_manager/widgets/custom_list_tile.dart';
import 'package:adguard_home_manager/providers/status_provider.dart';
import 'package:adguard_home_manager/functions/compare_versions.dart'; import 'package:adguard_home_manager/functions/compare_versions.dart';
import 'package:adguard_home_manager/functions/copy_clipboard.dart'; import 'package:adguard_home_manager/functions/copy_clipboard.dart';
import 'package:adguard_home_manager/models/clients.dart'; import 'package:adguard_home_manager/models/clients.dart';
@ -18,7 +19,6 @@ class AddedClientTile extends StatelessWidget {
final void Function(Client) onDelete; final void Function(Client) onDelete;
final Client? selectedClient; final Client? selectedClient;
final bool? splitView; final bool? splitView;
final String serverVersion;
const AddedClientTile({ const AddedClientTile({
Key? key, Key? key,
@ -29,11 +29,11 @@ class AddedClientTile extends StatelessWidget {
required this.onDelete, required this.onDelete,
this.selectedClient, this.selectedClient,
required this.splitView, required this.splitView,
required this.serverVersion
}) : super(key: key); }) : super(key: key);
@override @override
Widget build(BuildContext context) { Widget build(BuildContext context) {
final statusProvider = Provider.of<StatusProvider>(context);
final appConfigProvider = Provider.of<AppConfigProvider>(context); final appConfigProvider = Provider.of<AppConfigProvider>(context);
if (splitView == true) { if (splitView == true) {
@ -147,7 +147,7 @@ class AddedClientTile extends StatelessWidget {
Icons.search_rounded, Icons.search_rounded,
size: 19, size: 19,
color: serverVersionIsAhead( color: serverVersionIsAhead(
currentVersion: serverVersion, currentVersion: statusProvider.serverStatus!.serverVersion,
referenceVersion: 'v0.107.28', referenceVersion: 'v0.107.28',
referenceVersionBeta: 'v0.108.0-b.33' referenceVersionBeta: 'v0.108.0-b.33'
) == true ) == true
@ -261,7 +261,7 @@ class AddedClientTile extends StatelessWidget {
Icons.search_rounded, Icons.search_rounded,
size: 19, size: 19,
color: serverVersionIsAhead( color: serverVersionIsAhead(
currentVersion: serverVersion, currentVersion: statusProvider.serverStatus!.serverVersion,
referenceVersion: 'v0.107.28', referenceVersion: 'v0.107.28',
referenceVersionBeta: 'v0.108.0-b.33' referenceVersionBeta: 'v0.108.0-b.33'
) == true ) == true

View file

@ -75,7 +75,30 @@ class FiltersTripleColumn extends StatelessWidget {
} }
} }
Widget content() { return Scaffold(
appBar: AppBar(
surfaceTintColor: isDesktop(width) ? Colors.transparent : null,
title: Text(AppLocalizations.of(context)!.filters),
actions: [
IconButton(
onPressed: () async {
final result = await filteringProvider.fetchFilters();
if (result == false && context.mounted) {
showSnacbkar(
appConfigProvider: appConfigProvider,
label: AppLocalizations.of(context)!.errorLoadFilters,
color: Colors.red
);
}
},
icon: const Icon(Icons.refresh_rounded),
tooltip: AppLocalizations.of(context)!.refresh,
),
...actions
],
),
body: Builder(
builder: (context) {
switch (filteringProvider.loadStatus) { switch (filteringProvider.loadStatus) {
case LoadStatus.loading: case LoadStatus.loading:
return Row( return Row(
@ -324,31 +347,8 @@ class FiltersTripleColumn extends StatelessWidget {
default: default:
return const SizedBox(); return const SizedBox();
} }
}
return Scaffold(
appBar: AppBar(
surfaceTintColor: isDesktop(width) ? Colors.transparent : null,
title: Text(AppLocalizations.of(context)!.filters),
actions: [
IconButton(
onPressed: () async {
final result = await filteringProvider.fetchFilters();
if (result == false) {
showSnacbkar(
appConfigProvider: appConfigProvider,
label: AppLocalizations.of(context)!.errorLoadFilters,
color: Colors.red
);
}
}, },
icon: const Icon(Icons.refresh_rounded), )
tooltip: AppLocalizations.of(context)!.refresh,
),
...actions
],
),
body: content(),
); );
} }
} }

View file

@ -11,8 +11,8 @@ class LogsConfigOptions extends StatelessWidget {
final bool anonymizeClientIp; final bool anonymizeClientIp;
final void Function(bool) updateAnonymizeClientIp; final void Function(bool) updateAnonymizeClientIp;
final List<RetentionItem> retentionItems; final List<RetentionItem> retentionItems;
final String? retentionTime; final double? retentionTime;
final void Function(String?) updateRetentionTime; final void Function(double?) updateRetentionTime;
final void Function() onClear; final void Function() onClear;
final void Function() onConfirm; final void Function() onConfirm;
@ -130,14 +130,12 @@ class LogsConfigOptions extends StatelessWidget {
Padding( Padding(
padding: const EdgeInsets.symmetric(horizontal: 24), padding: const EdgeInsets.symmetric(horizontal: 24),
child: DropdownButtonFormField( child: DropdownButtonFormField(
items: retentionItems.map<DropdownMenuItem<String>>((item) { items: retentionItems.map((item) => DropdownMenuItem(
return DropdownMenuItem<String>( value: item.value,
value: item.value.toString(),
child: Text(item.label), child: Text(item.label),
); )).toList(),
}).toList(),
value: retentionTime, value: retentionTime,
onChanged: (value) => updateRetentionTime(value), onChanged: (value) => updateRetentionTime(value as double),
decoration: InputDecoration( decoration: InputDecoration(
border: const OutlineInputBorder( border: const OutlineInputBorder(
borderRadius: BorderRadius.all( borderRadius: BorderRadius.all(

View file

@ -79,7 +79,7 @@ class LogsConfigModalWidget extends StatefulWidget {
class _LogsConfigModalWidgetState extends State<LogsConfigModalWidget> { class _LogsConfigModalWidgetState extends State<LogsConfigModalWidget> {
bool generalSwitch = false; bool generalSwitch = false;
bool anonymizeClientIp = false; bool anonymizeClientIp = false;
String? retentionTime = ""; double? retentionTime;
List<RetentionItem> retentionItems = []; List<RetentionItem> retentionItems = [];
@ -101,8 +101,10 @@ class _LogsConfigModalWidgetState extends State<LogsConfigModalWidget> {
setState(() { setState(() {
generalSwitch = result['data']['enabled']; generalSwitch = result['data']['enabled'];
anonymizeClientIp = result['data']['anonymize_client_ip']; anonymizeClientIp = result['data']['anonymize_client_ip'];
retentionTime = result['data']['interval'].toString(); retentionTime = result['data']['interval'] != null
loadStatus = LoadStatus.loading; ? double.parse(result['data']['interval'].toString())
: null;
loadStatus = LoadStatus.loaded;
}); });
} }
else { else {
@ -191,7 +193,7 @@ class _LogsConfigModalWidgetState extends State<LogsConfigModalWidget> {
onClear: () => widget.onClear(), onClear: () => widget.onClear(),
onConfirm: () => widget.onConfirm({ onConfirm: () => widget.onConfirm({
"enabled": generalSwitch, "enabled": generalSwitch,
"interval": double.parse(retentionTime!), "interval": retentionTime,
"anonymize_client_ip": anonymizeClientIp "anonymize_client_ip": anonymizeClientIp
}) })
); );
@ -235,7 +237,7 @@ class _LogsConfigModalWidgetState extends State<LogsConfigModalWidget> {
onClear: () => widget.onClear(), onClear: () => widget.onClear(),
onConfirm: () => widget.onConfirm({ onConfirm: () => widget.onConfirm({
"enabled": generalSwitch, "enabled": generalSwitch,
"interval": double.parse(retentionTime!), "interval": retentionTime,
"anonymize_client_ip": anonymizeClientIp "anonymize_client_ip": anonymizeClientIp
}) })
); );