luckyimnotanigger/forgejo
1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2025-05-25 11:22:16 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

Remove polluted .ui.right (#26825)

Browse source 
Each change is tested manually line by line. There are too many changes
so I can't share dozens of screenshots.

In short:

1. `ui right` could be still used in `ui top attached header`, because
there is a special case.
2. A lot of `ui right` are just no-op, so they can be removed safely.
3. Some of the `ui right` should be replaced by `gt-float-right` (to
avoid breaking, leave them to the future).
4. A few of the `ui right` could be rewritten by flex.
This commit is contained in:
wxiaoguang 2023-08-31 10:29:59 +08:00 • committed by GitHub
parent 98f2bf23bc
commit 19a1e1b20e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
25 changed files with 51 additions and 72 deletions
Download patch file Download diff file Expand all files Collapse all files

5
web_src/css/base.css
View file

@ -1179,11 +1179,6 @@ img.ui.avatar,
font-size: 0.75em;
}
/* FIXME: this is a serious pollution, do not use this for "float: right" anymore */
.ui.right:not(.action) {
float: right;
}
.ui.form .ui.button {
font-weight: var(--font-weight-normal);
}

6
web_src/css/repo/release-tag.css
View file

@ -126,12 +126,8 @@
}
}
.repository.new.release .field .wrap_remove {
height: 38px;
}
.repository.new.release .field .attachment_edit {
width: 450px !important;
max-width: 48em;
}
.repository.new.release .markup {

2
web_src/js/components/RepoBranchTagSelector.vue
View file

@ -33,7 +33,7 @@
<div class="ui label" v-if="item.name===defaultBranch && mode === 'branches'">
{{ textDefaultBranchLabel }}
</div>
<a v-show="enableFeed && mode === 'branches'" role="button" class="rss-icon ui compact right" :href="rssURLPrefix + item.url" target="_blank" @click.stop>
<a v-show="enableFeed && mode === 'branches'" role="button" class="rss-icon gt-float-right" :href="rssURLPrefix + item.url" target="_blank" @click.stop>
<!-- creating a lot of Vue component is pretty slow, so we use a static SVG here -->
<svg width="14" height="14" class="svg octicon-rss"><use href="#svg-symbol-octicon-rss"/></svg>
</a>