Add testifylint to lint checks (#4535)

go-require lint is ignored for now

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4535
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Co-authored-by: TheFox0x7 <thefox0x7@gmail.com>
Co-committed-by: TheFox0x7 <thefox0x7@gmail.com>
This commit is contained in:
TheFox0x7 2024-07-30 19:41:10 +00:00 committed by Earl Warren
parent 94933470cd
commit 4de909747b
504 changed files with 5028 additions and 4680 deletions

View file

@ -19,6 +19,7 @@ import (
"code.gitea.io/gitea/tests"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
func TestOrgTeamEmailInvite(t *testing.T) {
@ -34,7 +35,7 @@ func TestOrgTeamEmailInvite(t *testing.T) {
user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 5})
isMember, err := organization.IsTeamMember(db.DefaultContext, team.OrgID, team.ID, user.ID)
assert.NoError(t, err)
require.NoError(t, err)
assert.False(t, isMember)
session := loginUser(t, "user1")
@ -52,7 +53,7 @@ func TestOrgTeamEmailInvite(t *testing.T) {
// get the invite token
invites, err := organization.GetInvitesByTeamID(db.DefaultContext, team.ID)
assert.NoError(t, err)
require.NoError(t, err)
assert.Len(t, invites, 1)
session = loginUser(t, user.Name)
@ -68,7 +69,7 @@ func TestOrgTeamEmailInvite(t *testing.T) {
session.MakeRequest(t, req, http.StatusOK)
isMember, err = organization.IsTeamMember(db.DefaultContext, team.OrgID, team.ID, user.ID)
assert.NoError(t, err)
require.NoError(t, err)
assert.True(t, isMember)
}
@ -86,7 +87,7 @@ func TestOrgTeamEmailInviteRedirectsExistingUser(t *testing.T) {
user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 5})
isMember, err := organization.IsTeamMember(db.DefaultContext, team.OrgID, team.ID, user.ID)
assert.NoError(t, err)
require.NoError(t, err)
assert.False(t, isMember)
// create the invite
@ -104,7 +105,7 @@ func TestOrgTeamEmailInviteRedirectsExistingUser(t *testing.T) {
// get the invite token
invites, err := organization.GetInvitesByTeamID(db.DefaultContext, team.ID)
assert.NoError(t, err)
require.NoError(t, err)
assert.Len(t, invites, 1)
// accept the invite
@ -132,7 +133,7 @@ func TestOrgTeamEmailInviteRedirectsExistingUser(t *testing.T) {
session = emptyTestSession(t)
baseURL, err := url.Parse(setting.AppURL)
assert.NoError(t, err)
require.NoError(t, err)
session.jar.SetCookies(baseURL, cr.Cookies())
// make the request
@ -144,7 +145,7 @@ func TestOrgTeamEmailInviteRedirectsExistingUser(t *testing.T) {
session.MakeRequest(t, req, http.StatusOK)
isMember, err = organization.IsTeamMember(db.DefaultContext, team.OrgID, team.ID, user.ID)
assert.NoError(t, err)
require.NoError(t, err)
assert.True(t, isMember)
}
@ -175,7 +176,7 @@ func TestOrgTeamEmailInviteRedirectsNewUser(t *testing.T) {
// get the invite token
invites, err := organization.GetInvitesByTeamID(db.DefaultContext, team.ID)
assert.NoError(t, err)
require.NoError(t, err)
assert.Len(t, invites, 1)
// accept the invite
@ -205,7 +206,7 @@ func TestOrgTeamEmailInviteRedirectsNewUser(t *testing.T) {
session = emptyTestSession(t)
baseURL, err := url.Parse(setting.AppURL)
assert.NoError(t, err)
require.NoError(t, err)
session.jar.SetCookies(baseURL, cr.Cookies())
// make the redirected request
@ -218,10 +219,10 @@ func TestOrgTeamEmailInviteRedirectsNewUser(t *testing.T) {
// get the new user
newUser, err := user_model.GetUserByName(db.DefaultContext, "doesnotexist")
assert.NoError(t, err)
require.NoError(t, err)
isMember, err := organization.IsTeamMember(db.DefaultContext, team.OrgID, team.ID, newUser.ID)
assert.NoError(t, err)
require.NoError(t, err)
assert.True(t, isMember)
}
@ -258,7 +259,7 @@ func TestOrgTeamEmailInviteRedirectsNewUserWithActivation(t *testing.T) {
// get the invite token
invites, err := organization.GetInvitesByTeamID(db.DefaultContext, team.ID)
assert.NoError(t, err)
require.NoError(t, err)
assert.Len(t, invites, 1)
// accept the invite
@ -281,7 +282,7 @@ func TestOrgTeamEmailInviteRedirectsNewUserWithActivation(t *testing.T) {
resp = MakeRequest(t, req, http.StatusOK)
user, err := user_model.GetUserByName(db.DefaultContext, "doesnotexist")
assert.NoError(t, err)
require.NoError(t, err)
ch := http.Header{}
ch.Add("Cookie", strings.Join(resp.Header()["Set-Cookie"], ";"))
@ -289,7 +290,7 @@ func TestOrgTeamEmailInviteRedirectsNewUserWithActivation(t *testing.T) {
session = emptyTestSession(t)
baseURL, err := url.Parse(setting.AppURL)
assert.NoError(t, err)
require.NoError(t, err)
session.jar.SetCookies(baseURL, cr.Cookies())
activateURL := fmt.Sprintf("/user/activate?code=%s", user.GenerateEmailActivateCode("doesnotexist@example.com"))
@ -314,7 +315,7 @@ func TestOrgTeamEmailInviteRedirectsNewUserWithActivation(t *testing.T) {
session.MakeRequest(t, req, http.StatusOK)
isMember, err := organization.IsTeamMember(db.DefaultContext, team.OrgID, team.ID, user.ID)
assert.NoError(t, err)
require.NoError(t, err)
assert.True(t, isMember)
}
@ -334,7 +335,7 @@ func TestOrgTeamEmailInviteRedirectsExistingUserWithLogin(t *testing.T) {
user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 5})
isMember, err := organization.IsTeamMember(db.DefaultContext, team.OrgID, team.ID, user.ID)
assert.NoError(t, err)
require.NoError(t, err)
assert.False(t, isMember)
// create the invite
@ -352,7 +353,7 @@ func TestOrgTeamEmailInviteRedirectsExistingUserWithLogin(t *testing.T) {
// get the invite token
invites, err := organization.GetInvitesByTeamID(db.DefaultContext, team.ID)
assert.NoError(t, err)
require.NoError(t, err)
assert.Len(t, invites, 1)
// note: the invited user has logged in
@ -373,6 +374,6 @@ func TestOrgTeamEmailInviteRedirectsExistingUserWithLogin(t *testing.T) {
session.MakeRequest(t, req, http.StatusOK)
isMember, err = organization.IsTeamMember(db.DefaultContext, team.OrgID, team.ID, user.ID)
assert.NoError(t, err)
require.NoError(t, err)
assert.True(t, isMember)
}