luckyimnotanigger/forgejo
1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2025-05-04 13:50:39 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Fix markdown meta parsing (#12817)

Browse source 
* Fix meta parsing and add minimal test

Signed-off-by: jolheiser <john.olheiser@gmail.com>

* Add license

Signed-off-by: jolheiser <john.olheiser@gmail.com>

* Require first separator and add more tests

Signed-off-by: jolheiser <john.olheiser@gmail.com>

* Make fmt

Signed-off-by: jolheiser <john.olheiser@gmail.com>

* Go lets this work gracefully 🙏

Signed-off-by: jolheiser <john.olheiser@gmail.com>

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
This commit is contained in:
John Olheiser 2020-09-12 20:48:47 -05:00 • committed by GitHub
parent f91bb745d6
commit b2bda11595
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 72 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

16
modules/markup/markdown/meta.go
View file

@ -25,20 +25,22 @@ func isYAMLSeparator(line string) bool {
// and returns the frontmatter metadata separated from the markdown content
func ExtractMetadata(contents string, out interface{}) (string, error) {
var front, body []string
var seps int
lines := strings.Split(contents, "\n")
for idx, line := range lines {
if seps == 2 {
front, body = lines[:idx], lines[idx:]
break
if idx == 0 {
// First line has to be a separator
if !isYAMLSeparator(line) {
return "", errors.New("frontmatter must start with a separator line")
}
continue
}
if isYAMLSeparator(line) {
seps++
continue
front, body = lines[1:idx], lines[idx+1:]
break
}
}
if len(front) == 0 && len(body) == 0 {
if len(front) == 0 {
return "", errors.New("could not determine metadata")
}