luckyimnotanigger/forgejo
1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2025-05-16 23:12:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Resolve TODO: Enable pagination on GiteaDownloader.GetComments() & update another TODO (#16963)

Browse source 
* Update TODO in migrations

* Resolve TODO: enable pagination on GiteaDownloader.GetComments()
This commit is contained in:
6543 2021-09-06 18:00:50 +02:00 • committed by GitHub
parent a807031a30
commit cf6d398485
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 40 additions and 44 deletions
Download patch file Download diff file Expand all files Collapse all files

5
modules/migrations/migrate.go
View file

@ -475,10 +475,7 @@ func Init() error {
return nil
}
// isIPPrivate reports whether ip is a private address, according to
// RFC 1918 (IPv4 addresses) and RFC 4193 (IPv6 addresses).
// from https://github.com/golang/go/pull/42793
// TODO remove if https://github.com/golang/go/issues/29146 got resolved
// TODO: replace with `ip.IsPrivate()` if min go version is bumped to 1.17
func isIPPrivate(ip net.IP) bool {
if ip4 := ip.To4(); ip4 != nil {
return ip4[0] == 10 ||