mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2025-06-08 07:37:38 +00:00
chore: QoL improvements to tests (#7917)
- Use mock helper functions, instead of home-brew solutions. - Disable cron jobs that are not important to be run during integration tests and might even interfere. - Avoid sleeping unnecessary, if there's some requirement then sleep or retry until that requirement is met. - Avoid trying to deliver webhooks that will always result in a failure. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/7917 Reviewed-by: Michael Kriese <michael.kriese@gmx.de> Co-authored-by: Gusted <postmaster@gusted.xyz> Co-committed-by: Gusted <postmaster@gusted.xyz>
This commit is contained in:
parent
112ba66637
commit
fa2a135f68
44 changed files with 155 additions and 264 deletions
|
@ -21,6 +21,7 @@ import (
|
|||
"forgejo.org/modules/json"
|
||||
"forgejo.org/modules/lfs"
|
||||
"forgejo.org/modules/setting"
|
||||
"forgejo.org/modules/test"
|
||||
"forgejo.org/tests"
|
||||
|
||||
"github.com/stretchr/testify/assert"
|
||||
|
@ -228,9 +229,7 @@ func TestAPILFSBatch(t *testing.T) {
|
|||
|
||||
t.Run("FileTooBig", func(t *testing.T) {
|
||||
defer tests.PrintCurrentTest(t)()
|
||||
|
||||
oldMaxFileSize := setting.LFS.MaxFileSize
|
||||
setting.LFS.MaxFileSize = 2
|
||||
defer test.MockVariableValue(&setting.LFS.MaxFileSize, 2)()
|
||||
|
||||
req := newRequest(t, &lfs.BatchRequest{
|
||||
Operation: "upload",
|
||||
|
@ -245,8 +244,6 @@ func TestAPILFSBatch(t *testing.T) {
|
|||
assert.NotNil(t, br.Objects[0].Error)
|
||||
assert.Equal(t, http.StatusUnprocessableEntity, br.Objects[0].Error.Code)
|
||||
assert.Equal(t, "Size must be less than or equal to 2", br.Objects[0].Error.Message)
|
||||
|
||||
setting.LFS.MaxFileSize = oldMaxFileSize
|
||||
})
|
||||
|
||||
t.Run("AddMeta", func(t *testing.T) {
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue