Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367)

Co-authored-by: Renovate Bot <forgejo-renovate-action@forgejo.org>
Co-committed-by: Renovate Bot <forgejo-renovate-action@forgejo.org>

modules/translation/i18n/i18n_test.go

@@ -166,7 +166,7 @@ commits = fallback value for commits
 
 	found = lang1.HasKey("no-such")
 	assert.False(t, found)
-	assert.EqualValues(t, "no-such", lang1.TrString("no-such"))
+	assert.Equal(t, "no-such", lang1.TrString("no-such"))
 	require.NoError(t, ls.Close())
 }
 

modules/translation/i18n/localestore.go

@@ -107,11 +107,12 @@ func RecursivelyAddTranslationsFromJSON(locale *locale, object map[string]any, p
 		case string:
 			// Check whether we are adding a plural form to the parent object, or a new nested JSON object.
 
-			if key == "zero" || key == "one" || key == "two" || key == "few" || key == "many" {
+			switch key {
+			case "zero", "one", "two", "few", "many":
 				locale.newStyleMessages[prefix+PluralFormSeparator+key] = v
-			} else if key == "other" {
+			case "other":
 				locale.newStyleMessages[prefix] = v
-			} else {
+			default:
 				locale.newStyleMessages[fullkey] = v
 			}
 

modules/translation/translation_test.go

@@ -16,19 +16,19 @@ import (
 func TestTrSize(t *testing.T) {
 	l := NewLocale("")
 	size := int64(1)
-	assert.EqualValues(t, "1 munits.data.b", l.TrSize(size).String())
+	assert.Equal(t, "1 munits.data.b", l.TrSize(size).String())
 	size *= 2048
-	assert.EqualValues(t, "2 munits.data.kib", l.TrSize(size).String())
+	assert.Equal(t, "2 munits.data.kib", l.TrSize(size).String())
 	size *= 2048
-	assert.EqualValues(t, "4 munits.data.mib", l.TrSize(size).String())
+	assert.Equal(t, "4 munits.data.mib", l.TrSize(size).String())
 	size *= 2048
-	assert.EqualValues(t, "8 munits.data.gib", l.TrSize(size).String())
+	assert.Equal(t, "8 munits.data.gib", l.TrSize(size).String())
 	size *= 2048
-	assert.EqualValues(t, "16 munits.data.tib", l.TrSize(size).String())
+	assert.Equal(t, "16 munits.data.tib", l.TrSize(size).String())
 	size *= 2048
-	assert.EqualValues(t, "32 munits.data.pib", l.TrSize(size).String())
+	assert.Equal(t, "32 munits.data.pib", l.TrSize(size).String())
 	size *= 128
-	assert.EqualValues(t, "4 munits.data.eib", l.TrSize(size).String())
+	assert.Equal(t, "4 munits.data.eib", l.TrSize(size).String())
 }
 
 func TestPrettyNumber(t *testing.T) {
@@ -38,15 +38,15 @@ func TestPrettyNumber(t *testing.T) {
 	allLangMap["id-ID"] = &LangType{Lang: "id-ID", Name: "Bahasa Indonesia"}
 
 	l := NewLocale("id-ID")
-	assert.EqualValues(t, "1.000.000", l.PrettyNumber(1000000))
-	assert.EqualValues(t, "1.000.000,1", l.PrettyNumber(1000000.1))
-	assert.EqualValues(t, "1.000.000", l.PrettyNumber("1000000"))
-	assert.EqualValues(t, "1.000.000", l.PrettyNumber("1000000.0"))
-	assert.EqualValues(t, "1.000.000,1", l.PrettyNumber("1000000.1"))
+	assert.Equal(t, "1.000.000", l.PrettyNumber(1000000))
+	assert.Equal(t, "1.000.000,1", l.PrettyNumber(1000000.1))
+	assert.Equal(t, "1.000.000", l.PrettyNumber("1000000"))
+	assert.Equal(t, "1.000.000", l.PrettyNumber("1000000.0"))
+	assert.Equal(t, "1.000.000,1", l.PrettyNumber("1000000.1"))
 
 	l = NewLocale("nosuch")
-	assert.EqualValues(t, "1,000,000", l.PrettyNumber(1000000))
-	assert.EqualValues(t, "1,000,000.1", l.PrettyNumber(1000000.1))
+	assert.Equal(t, "1,000,000", l.PrettyNumber(1000000))
+	assert.Equal(t, "1,000,000.1", l.PrettyNumber(1000000.1))
 }
 
 func TestGetPluralRule(t *testing.T) {