forgejo

luckyimnotanigger/forgejo

Fork 0

mirror of https://codeberg.org/forgejo/forgejo.git synced 2025-05-04 13:50:39 +00:00

Commit graph

Author SHA1 Message Date

Author	SHA1	Message	Date
oliverpool	16879b07d2	[PORT] drop utils.IsExternalURL (and expand IsRiskyRedirectURL tests) (#3167 ) Related to #2773 Related to Refactor URL detection [gitea#29960](https://github.com/go-gitea/gitea/pull/29960) Related to Refactor external URL detection [gitea#29973](https://github.com/go-gitea/gitea/pull/29973) I added a bunch of tests to `httplib.TestIsRiskyRedirectURL` and some cases should be better handled (however it is not an easy task). I also ported the removal of `utils.IsExternalURL`, since it prevents duplicated (subtle) code. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3167 Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org> Reviewed-by: Gusted <gusted@noreply.codeberg.org> Co-authored-by: oliverpool <git@olivier.pfad.fr> Co-committed-by: oliverpool <git@olivier.pfad.fr>	2024-04-15 13:03:08 +00:00
wxiaoguang	b71cb7acdc	Use fetch to send requests to create issues/comments (#25258 ) Follow #23290 Network error won't make content lost. And this is a much better approach than "loading-button". The UI is not perfect and there are still some TODOs, they can be done in following PRs, not a must in this PR's scope. <details> ![image](`c94ba958`-aa46-4747-8ddf-6584deeed25c) </details>	2023-06-16 06:32:43 +00:00

oliverpool

16879b07d2

[PORT] drop utils.IsExternalURL (and expand IsRiskyRedirectURL tests) (#3167 )

Related to  #2773
Related to Refactor URL detection [gitea#29960](https://github.com/go-gitea/gitea/pull/29960)
Related to Refactor external URL detection [gitea#29973](https://github.com/go-gitea/gitea/pull/29973)

I added a bunch of tests to `httplib.TestIsRiskyRedirectURL` and some cases should be better handled (however it is not an easy task).

I also ported the removal of `utils.IsExternalURL`, since it prevents duplicated (subtle) code.

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3167
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Co-authored-by: oliverpool <git@olivier.pfad.fr>
Co-committed-by: oliverpool <git@olivier.pfad.fr>

2024-04-15 13:03:08 +00:00

wxiaoguang

b71cb7acdc

Use fetch to send requests to create issues/comments (#25258 )

Follow #23290

Network error won't make content lost. And this is a much better
approach than "loading-button".

The UI is not perfect and there are still some TODOs, they can be done
in following PRs, not a must in this PR's scope.

<details>


![image](c94ba958-aa46-4747-8ddf-6584deeed25c)

</details>

2023-06-16 06:32:43 +00:00

2 commits