forgejo/tests/integration
Earl Warren adc273e3a8
Some checks failed
testing-integration / test-unit (push) Has been skipped
testing-integration / test-sqlite (push) Has been skipped
testing / backend-checks (push) Has been skipped
testing / frontend-checks (push) Has been skipped
testing / test-unit (push) Has been skipped
testing / test-e2e (push) Has been skipped
testing / test-mysql (push) Has been skipped
testing / test-pgsql (push) Has been skipped
testing / test-sqlite (push) Has been skipped
testing / test-remote-cacher (redis) (push) Has been skipped
testing / test-remote-cacher (valkey) (push) Has been skipped
testing / test-remote-cacher (garnet) (push) Has been skipped
testing / test-remote-cacher (redict) (push) Has been skipped
testing / security-check (push) Has been skipped
Integration tests for the release process / release-simulation (push) Has been cancelled
/ release (push) Has been cancelled
fix: do not ignore automerge while a PR is checking for conflicts (#8189)
Automerge can be ignored when the following race happens:

* Conflict check is happening on a repository and
  `pr.Status = issues_model.PullRequestStatusChecking` for all open pull
  requests (this happens every time a pull request is merged).
* While the conflict check is ongoing, an event (Forgejo Actions being
  successful for instance) happens and and `StartPRCheckAndAutoMerge*` is called.
* Because `pr.CanAutoMerge()` is false, the pull request is not
  selected and not added to the automerge queue.
* When the conflict check completes and `pr.CanAutoMerge()` becomes
  true, there no longer is a task in the auto merge queue and the
  auto merge does not happen.

This is fixed by adding a task to the auto merge queue when the conflict check for a pull request completes. This is done when the mutx protecting the conflict check task is released to prevent a deadlock when a synchronous queues are used in the following situation:

* the conflict check task finds the pull request is mergeable
* it schedules the auto merge tasks that finds it must be merged
* merging concludes with scheduling a conflict check task

Avoid an extra loop where a conflict check task queues an auto merge task that will schedule a conflict check task if the pull request can be merged. The auto merge row is removed from the database before merging. It would otherwise be removed after the merge commit is received via the git hook which happens asynchronously and can lead to a race.

StartPRCheckAndAutoMerge is modified to re-use HeadCommitID when available, such as when called after a pull request conflict check.

---

A note on tests: they cover the new behavior, i.e. automerge being triggered by a successful conflict check. This is also on the critical paths for every test that involve creating, merging or updating a pull request.

- `tests/integration/git_test.go`
- `tests/integration/actions_commit_status_test.go`
- `tests/integration/api_helper_for_declarative_test.go`
- `tests/integration/patch_status_test.go`
- `tests/integration/pull_merge_test.go`

The [missing fixture file](https://codeberg.org/forgejo/forgejo/pulls/8189/files#diff-b86fdd79108b3ba3cb2e56ffcfd1be2a7b32f46c) for the auto merge table can be verified to be necessary simply by removing it an observing that the integration tests fail.

The [scheduling of the auto merge task](https://codeberg.org/forgejo/forgejo/pulls/8189/files#diff-9489262e93967f6bb2db41837f37c06f4e70d978) in `testPR` can be verified to be required by moving it in the `testPRProtected` function and observing that the tests hang forever because of the deadlock.

## Checklist

The [contributor guide](https://forgejo.org/docs/next/contributor/) contains information that will be helpful to first time contributors. There also are a few [conditions for merging Pull Requests in Forgejo repositories](https://codeberg.org/forgejo/governance/src/branch/main/PullRequestsAgreement.md). You are also welcome to join the [Forgejo development chatroom](https://matrix.to/#/#forgejo-development:matrix.org).

### Tests

- I added test coverage for Go changes...
  - [ ] in their respective `*_test.go` for unit tests.
  - [x] in the `tests/integration` directory if it involves interactions with a live Forgejo server.
- I added test coverage for JavaScript changes...
  - [ ] in `web_src/js/*.test.js` if it can be unit tested.
  - [ ] in `tests/e2e/*.test.e2e.js` if it requires interactions with a live Forgejo server (see also the [developer guide for JavaScript testing](https://codeberg.org/forgejo/forgejo/src/branch/forgejo/tests/e2e/README.md#end-to-end-tests)).

### Documentation

- [ ] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change.
- [x] I did not document these changes and I do not expect someone else to do it.

### Release notes

- [ ] I do not want this change to show in the release notes.
- [x] I want the title to show in the release notes with a link to this pull request.
- [ ] I want the content of the `release-notes/<pull request number>.md` to be be used for the release notes instead of the title.

<!--start release-notes-assistant-->

## Release notes
<!--URL:https://codeberg.org/forgejo/forgejo-->
- Bug fixes
  - [PR](https://codeberg.org/forgejo/forgejo/pulls/8189): <!--number 8189 --><!--line 0 --><!--description ZG8gbm90IGlnbm9yZSBhdXRvbWVyZ2Ugd2hpbGUgYSBQUiBpcyBjaGVja2luZyBmb3IgY29uZmxpY3Rz-->do not ignore automerge while a PR is checking for conflicts<!--description-->
<!--end release-notes-assistant-->

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/8189
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
Reviewed-by: Lucas <sclu1034@noreply.codeberg.org>
Co-authored-by: Earl Warren <contact@earl-warren.org>
Co-committed-by: Earl Warren <contact@earl-warren.org>
2025-06-17 10:58:07 +02:00
..
fixtures fix: ensure consistent empty repository topics field (#7920) 2025-05-29 22:39:53 +02:00
migration-test feat: use XORM EngineGroup instead of single Engine connection (#7212) 2025-03-30 11:34:02 +00:00
schemas verify nodeinfo response by schema (#22137) 2022-12-17 01:22:34 -05:00
actions_commit_status_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
actions_job_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
actions_log_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
actions_route_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
actions_run_now_done_notification_test.go Actions Done Notification (#7491) 2025-04-24 15:15:24 +00:00
actions_runner_test.go chore: QoL improvements to tests (#7917) 2025-05-21 15:45:56 +02:00
actions_trigger_test.go fix: Add error reporting to PRs with invalid workflows (#7930) 2025-05-22 16:48:48 +02:00
actions_variables_test.go chore: merge tests.AddFixtures and unittest.OverrideFixtures (#7648) 2025-04-25 09:14:33 +00:00
activitypub_client_test.go feat(activitiypub): enable HTTP signatures on all ActivityPub endpoints (#7035) 2025-04-03 15:24:15 +00:00
admin_config_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
admin_user_test.go chore: merge tests.AddFixtures and unittest.OverrideFixtures (#7648) 2025-04-25 09:14:33 +00:00
api_actions_artifact_test.go chore(cleanup): replaces unnecessary calls to formatting functions by non-formatting equivalents (#7994) 2025-05-29 17:34:29 +02:00
api_actions_artifact_v4_test.go chore(cleanup): replaces unnecessary calls to formatting functions by non-formatting equivalents (#7994) 2025-05-29 17:34:29 +02:00
api_activitypub_actor_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
api_activitypub_person_test.go fix various typos (#7690) 2025-04-28 06:46:29 +00:00
api_activitypub_repository_test.go feat(activitiypub): enable HTTP signatures on all ActivityPub endpoints (#7035) 2025-04-03 15:24:15 +00:00
api_admin_actions_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
api_admin_org_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
api_admin_test.go feat: auto cleanup of offline runners (#7803) 2025-06-08 00:13:37 +02:00
api_block_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
api_branch_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
api_comment_attachment_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
api_comment_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
api_federation_httpsig_test.go add port and schema to federation host (#7203) 2025-04-16 08:07:51 +00:00
api_feed_plain_text_titles_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
api_forgejo_root_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
api_forgejo_version_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
api_fork_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
api_gitignore_templates_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
api_gpg_keys_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
api_health_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
api_helper_for_declarative_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
api_httpsig_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
api_issue_attachment_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
api_issue_config_test.go API: enforce sha requirement on POST /repos/{owner}/{repo}/contents (#8139) 2025-06-12 00:13:39 +02:00
api_issue_label_test.go fix: remove redundant permission check in RemoveLabel (#7835) 2025-05-14 16:20:43 +00:00
api_issue_milestone_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
api_issue_pin_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
api_issue_reaction_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
api_issue_stopwatch_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
api_issue_subscription_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
api_issue_templates_test.go API: enforce sha requirement on POST /repos/{owner}/{repo}/contents (#8139) 2025-06-12 00:13:39 +02:00
api_issue_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
api_issue_tracked_time_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
api_keys_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
api_label_templates_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
api_license_templates_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
api_misc_test.go feat(sec): Add SSH signing support for instances (#6897) 2025-04-11 13:25:35 +00:00
api_nodeinfo_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
api_notification_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
api_oauth2_apps_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
api_org_actions_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
api_org_avatar_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
api_org_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
api_packages_alpine_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
api_packages_alt_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
api_packages_arch_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
api_packages_cargo_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
api_packages_chef_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
api_packages_composer_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
api_packages_conan_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
api_packages_conda_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
api_packages_container_cleanup_sha256_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
api_packages_container_test.go feat: support artifact uploads for OCI container packages (#8070) 2025-06-09 10:14:53 +02:00
api_packages_cran_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
api_packages_debian_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
api_packages_generic_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
api_packages_goproxy_test.go chore: QoL improvements to tests (#7917) 2025-05-21 15:45:56 +02:00
api_packages_helm_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
api_packages_maven_test.go fix: maven use groupId:artifactId for package name concatenation (#6352) 2025-06-01 09:02:29 +02:00
api_packages_npm_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
api_packages_nuget_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
api_packages_pub_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
api_packages_pypi_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
api_packages_rpm_test.go feat: replace go-rpmutils library with our own (#7953) 2025-05-25 12:30:04 +02:00
api_packages_rubygems_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
api_packages_swift_test.go fix linting 2025-04-28 16:41:33 +02:00
api_packages_test.go feat: allow access to /api/v1/packages/{username} without token (#7716) 2025-04-29 14:37:19 +00:00
api_packages_vagrant_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
api_private_serv_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
api_pull_commits_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
api_pull_review_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
api_pull_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
api_push_mirror_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
api_quota_management_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
api_quota_use_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
api_releases_test.go fix: allow instance API URLs in release assets (#7644) 2025-06-09 10:01:59 +02:00
api_repo_actions_test.go fix: rename api.{List,}ActionRun to api.{List,}RepoActionRun (#8066) 2025-06-04 07:09:06 +02:00
api_repo_activities_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
api_repo_archive_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
api_repo_avatar_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
api_repo_branch_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
api_repo_collaborator_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
api_repo_compare_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
api_repo_edit_test.go fix: validate input for default_{merge,update}_style (#7395) 2025-03-31 03:33:18 +00:00
api_repo_file_create_test.go Show if commit is signed in activity feed and unify sha box (#6933) 2025-05-03 10:54:52 +00:00
api_repo_file_delete_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
api_repo_file_get_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
api_repo_file_helpers.go API: enforce sha requirement on POST /repos/{owner}/{repo}/contents (#8139) 2025-06-12 00:13:39 +02:00
api_repo_file_update_test.go API: enforce sha requirement on POST /repos/{owner}/{repo}/contents (#8139) 2025-06-12 00:13:39 +02:00
api_repo_files_change_test.go API: enforce sha requirement on POST /repos/{owner}/{repo}/contents (#8139) 2025-06-12 00:13:39 +02:00
api_repo_get_contents_list_test.go feat(api): add last_commit_when to contents response (#7418) 2025-04-18 09:31:40 +00:00
api_repo_get_contents_test.go feat(api): add last_commit_when to contents response (#7418) 2025-04-18 09:31:40 +00:00
api_repo_git_blobs_test.go api: GitBlob consistent naming 2025-06-13 11:35:14 +02:00
api_repo_git_commits_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
api_repo_git_hook_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
api_repo_git_notes_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
api_repo_git_ref_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
api_repo_git_tags_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
api_repo_git_trees_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
api_repo_hook_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
api_repo_languages_test.go chore: QoL improvements to tests (#7917) 2025-05-21 15:45:56 +02:00
api_repo_lfs_locks_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
api_repo_lfs_migrate_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
api_repo_lfs_test.go chore: QoL improvements to tests (#7917) 2025-05-21 15:45:56 +02:00
api_repo_pulls_test.go chore: use correct import (#7371) 2025-03-28 12:06:07 +00:00
api_repo_raw_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
api_repo_secrets_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
api_repo_tags_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
api_repo_teams_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
api_repo_test.go fix: do not fail when release or wiki is set in /repos/migrate API (#8155) 2025-06-12 11:12:58 +02:00
api_repo_topic_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
api_repo_variables_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
api_settings_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
api_team_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
api_team_user_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
api_token_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
api_twofa_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
api_user_actions_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
api_user_avatar_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
api_user_email_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
api_user_follow_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
api_user_heatmap_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
api_user_info_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
api_user_org_perm_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
api_user_orgs_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
api_user_search_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
api_user_secrets_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
api_user_star_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
api_user_variables_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
api_user_watch_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
api_wiki_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
appearance_settings_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
archived_labels_display_test.go Add integration test for (non-)archived label properties 2024-04-01 21:38:34 +05:00
attachment_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
auth_ldap_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
auth_token_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
avatar.png Add API for changing Avatars (#25369) 2023-06-29 23:22:55 +00:00
benchmarks_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
block_test.go chore: merge tests.AddFixtures and unittest.OverrideFixtures (#7648) 2025-04-25 09:14:33 +00:00
branches_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
change_default_branch_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
cmd_admin_test.go feat: add admin user reset-mfa CLI command (#8047) 2025-06-05 10:40:21 +02:00
cmd_forgejo_actions_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
cmd_forgejo_f3_test.go chore(upgrade): urfave/cli from v2 to v3 (#8035) 2025-06-01 22:16:37 +02:00
cmd_keys_test.go chore(upgrade): urfave/cli from v2 to v3 (#8035) 2025-06-01 22:16:37 +02:00
codeowner_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
comment_roles_system_test.go chore: merge tests.AddFixtures and unittest.OverrideFixtures (#7648) 2025-04-25 09:14:33 +00:00
comment_roles_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
commit_status_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
common_navigation_test.go feat(ui): make JS asset load error message translatable (#7388) 2025-04-01 16:14:38 +00:00
compare_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
cors_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
create_no_session_test.go chore: QoL improvements to tests (#7917) 2025-05-21 15:45:56 +02:00
csrf_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
db_collation_test.go chore: QoL improvements to tests (#7917) 2025-05-21 15:45:56 +02:00
delete_user_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
devtest_error_test.go chore(tests): fix testing failure caused by dep update (#7376) 2025-03-29 08:17:44 +00:00
disable_forgotten_password_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
doctor_packages_nuget_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
download_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
dummy_lang_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
dump_restore_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
easymde_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
editor_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
empty_repo_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
eventsource_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
explore_code_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
explore_org_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
explore_repos_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
explore_user_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
feed_repo_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
feed_user_test.go chore: merge tests.AddFixtures and unittest.OverrideFixtures (#7648) 2025-04-25 09:14:33 +00:00
forgejo_confirmation_repo_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
forgejo_git_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
git_helper_for_declarative_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
git_push_test.go chore: fix tests for old git versions (#8144) 2025-06-11 09:38:15 +02:00
git_smart_http_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
git_test.go chore: QoL improvements to tests (#7917) 2025-05-21 15:45:56 +02:00
goget_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
html_helper.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
incoming_email_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
integration_test.go chore(upgrade): urfave/cli from v2 to v3 (#8035) 2025-06-01 22:16:37 +02:00
issue_subscribe_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
issue_test.go port(gitea): Retain issue/pull sort type (#8067) 2025-06-06 15:30:52 +02:00
issue_tracked_time_test.go fix(ui): display user-friendly message for range error (#7420) 2025-04-02 15:48:09 +00:00
last_updated_time_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
lfs_getobject_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
lfs_local_endpoint_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
lfs_view_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
linguist_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
links_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
markup_external_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
markup_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
mention_test.go feat(ui): highlight user mention in comments and commit messages 2024-11-14 14:08:12 +01:00
migrate_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
milestone_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
mirror_pull_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
mirror_push_test.go Fix TestSSHPushMirror/Normal/Check_mirrored_content test (#7852) 2025-05-24 11:06:48 +02:00
new_org_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
nonascii_branches_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
notification_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
oauth_test.go fix: remove trailing slash from the issuer in oauth claims (#8028) 2025-06-10 20:46:17 +02:00
opengraph_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
org_count_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
org_nav_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
org_project_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
org_settings_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
org_team_invite_test.go chore: QoL improvements to tests (#7917) 2025-05-21 15:45:56 +02:00
org_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
patch_status_test.go fix: do not ignore automerge while a PR is checking for conflicts (#8189) 2025-06-17 10:58:07 +02:00
private-testing.key Kd/ci playwright go test (#20123) 2022-09-02 15:18:23 -04:00
private_project_test.go chore: merge tests.AddFixtures and unittest.OverrideFixtures (#7648) 2025-04-25 09:14:33 +00:00
privateactivity_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
proctected_branch_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
project_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
pull_commit_test.go Implement single-commit PR review flow (#7155) 2025-06-17 09:31:50 +02:00
pull_compare_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
pull_create_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
pull_diff_test.go Implement single-commit PR review flow (#7155) 2025-06-17 09:31:50 +02:00
pull_editable_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
pull_files_test.go Implement single-commit PR review flow (#7155) 2025-06-17 09:31:50 +02:00
pull_icon_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
pull_merge_test.go chore: QoL improvements to tests (#7917) 2025-05-21 15:45:56 +02:00
pull_reopen_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
pull_request_task_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
pull_review_test.go API: enforce sha requirement on POST /repos/{owner}/{repo}/contents (#8139) 2025-06-12 00:13:39 +02:00
pull_status_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
pull_summary_test.go Add test for pull summary 2024-03-22 07:11:52 +01:00
pull_test.go Implement single-commit PR review flow (#7155) 2025-06-17 09:31:50 +02:00
pull_update_test.go fix: remove artificial delay for PR update (#7773) 2025-05-04 21:54:55 +00:00
pull_wip_convert_test.go Add test for add/remove WIP link display 2024-03-21 19:33:02 +05:00
quota_use_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
README.md fix: do not ignore automerge while a PR is checking for conflicts (#8189) 2025-06-17 10:58:07 +02:00
release_feed_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
release_test.go chore: QoL improvements to tests (#7917) 2025-05-21 15:45:56 +02:00
remote_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
rename_branch_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
repo_activity_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
repo_archive_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
repo_archive_text_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
repo_badges_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
repo_branch_test.go fix: Remove "create branch" button on mirrored repos (#7640) 2025-05-14 23:26:12 +00:00
repo_citation_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
repo_collaborator_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
repo_commit_test.go chore: extract commit header template (#8061) 2025-06-05 11:35:08 +02:00
repo_commits_search_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
repo_commits_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
repo_delete_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
repo_flags_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
repo_fork_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
repo_generate_test.go fix: do not check for object_format_name field (#8202) 2025-06-17 07:47:00 +02:00
repo_git_note_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
repo_issue_title_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
repo_mergecommit_revert_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
repo_migrate_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
repo_migration_ui_test.go feat(ui/migrations): clarify desired autocompletion type for clone_addr (#7377) 2025-03-30 11:31:42 +00:00
repo_pagination_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
repo_search_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
repo_settings_hook_test.go chore: QoL improvements to tests (#7917) 2025-05-21 15:45:56 +02:00
repo_settings_test.go chore(cleanup): replaces unnecessary calls to formatting functions by non-formatting equivalents (#7994) 2025-05-29 17:34:29 +02:00
repo_signed_tag_test.go fix: make test suite run on older git version (#8188) 2025-06-14 19:50:58 +02:00
repo_starwatch_test.go feat(ui): messages for empty usercards (#7947) 2025-05-23 23:34:40 +02:00
repo_sync_fork_test.go fix(ui): multiple fixes of sync fork UI (#7740) 2025-05-02 14:25:05 +00:00
repo_tag_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
repo_test.go fix: handle viewing a submodule entry (#7261) 2025-04-03 15:32:55 +00:00
repo_topic_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
repo_view_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
repo_watch_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
repo_webhook_test.go Actions Failure, Succes, Recover Webhooks (#7508) 2025-06-03 14:29:19 +02:00
repo_wiki_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
repofiles_change_test.go API: enforce sha requirement on POST /repos/{owner}/{repo}/contents (#8139) 2025-06-12 00:13:39 +02:00
runner_test.go chore: merge tests.AddFixtures and unittest.OverrideFixtures (#7648) 2025-04-25 09:14:33 +00:00
session_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
setting_test.go feat(ui): show size constraints of custom avatar (#7998) 2025-06-14 16:35:50 +02:00
signin_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
signing_git_test.go fix: make test suite run on older git version (#8188) 2025-06-14 19:50:58 +02:00
signout_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
signup_test.go chore: QoL improvements to tests (#7917) 2025-05-21 15:45:56 +02:00
ssh-signing-key feat(sec): Add SSH signing support for instances (#6897) 2025-04-11 13:25:35 +00:00
ssh-signing-key.pub feat(sec): Add SSH signing support for instances (#6897) 2025-04-11 13:25:35 +00:00
ssh_key_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
swagger_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
timetracking_test.go chore: QoL improvements to tests (#7917) 2025-05-21 15:45:56 +02:00
translations_test.go Replace the 'relative-time' element scripting with custom, translatable rewrite (#6154) 2025-05-03 14:11:01 +00:00
user_avatar_test.go feat: add label for avatar settings (#7678) 2025-04-29 13:31:07 +00:00
user_count_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
user_dashboard_test.go feat(ui): make JS asset load error message translatable (#7388) 2025-04-01 16:14:38 +00:00
user_federationhost_xorm_test.go feat(activitiypub): enable HTTP signatures on all ActivityPub endpoints (#7035) 2025-04-03 15:24:15 +00:00
user_profile_activity_test.go fix(ui): prepend AppSubURL to visibility hint URLs (#7379) 2025-03-30 05:04:36 +00:00
user_profile_follows_test.go feat(ui): messages for empty usercards (#7947) 2025-05-23 23:34:40 +02:00
user_profile_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
user_redirect_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
user_test.go feat: add validating user password as trace region (#7981) 2025-05-28 14:46:23 +02:00
version_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
view_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
webfinger_test.go chore: QoL improvements to tests (#7917) 2025-05-21 15:45:56 +02:00
webhook_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
wiki_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
xss_test.go chore: merge tests.AddFixtures and unittest.OverrideFixtures (#7648) 2025-04-25 09:14:33 +00:00

Integration tests

Thank you for your effort to provide good software tests for Forgejo. Please also read the general testing instructions in the Forgejo contributor documentation.

This file is meant to provide specific information for the integration tests as well as some tips and tricks you should know.

Feel free to extend this file with more instructions if you feel like you have something to share!

How to run the tests?

Before running any tests, please ensure you perform a clean build:

make clean build

Integration tests can be run with make commands for the appropriate backends, namely:

make test-sqlite
make test-pgsql
make test-mysql

Run tests via local forgejo runner

If you have a forgejo runner, you can use it to run the test jobs:

Run all jobs

forgejo-runner exec -W .forgejo/workflows/testing.yml --event=pull_request

Warning: This file defines many jobs, so it will be resource-intensive and therefore not recommended.

Run single job

forgejo-runner exec -W .forgejo/workflows/testing.yml --event=pull_request -j <job_name>

You can list all job names via:

forgejo-runner exec -W .forgejo/workflows/testing.yml --event=pull_request -l

Run sqlite integration tests

Start tests

make test-sqlite

Run MySQL integration tests

Setup a MySQL database inside docker

docker run -e MYSQL_DATABASE=test -e MYSQL_ALLOW_EMPTY_PASSWORD=yes -p 3306:3306 --rm --name mysql mysql:latest #(Ctrl-c to stop the database)

Start tests based on the database container

TEST_MYSQL_HOST=localhost:3306 TEST_MYSQL_DBNAME=test?multiStatements=true TEST_MYSQL_USERNAME=root TEST_MYSQL_PASSWORD='' make test-mysql

Run pgsql integration tests

Setup a pgsql database inside docker

docker run -e "POSTGRES_DB=test" -e POSTGRES_PASSWORD=postgres POSTGRESQL_FSYNC=off POSTGRESQL_EXTRA_FLAGS="-c full_page_writes=off" -p 5432:5432 --rm --name pgsql data.forgejo.org/oci/bitnami/postgresql:16 #(Ctrl-c to stop the database)

Start tests based on the database container

TEST_STORAGE_TYPE=local TEST_PGSQL_HOST=localhost:5432 TEST_PGSQL_DBNAME=test TEST_PGSQL_USERNAME=postgres TEST_PGSQL_PASSWORD=postgres make 'test-pgsql#Test'

Running individual tests

Example command to run GPG test:

For SQLite:

make test-sqlite#GPG

For other databases (replace mysql to pgsql):

TEST_MYSQL_HOST=localhost:1433 TEST_MYSQL_DBNAME=test TEST_MYSQL_USERNAME=sa TEST_MYSQL_PASSWORD=MwantsaSecurePassword1 make test-mysql#GPG

Setting timeouts for declaring long-tests and long-flushes

We appreciate that some testing machines may not be very powerful and the default timeouts for declaring a slow test or a slow clean-up flush may not be appropriate.

You can either:

  • Within the test ini file set the following section:
[integration-tests]
SLOW_TEST = 10s ; 10s is the default value
SLOW_FLUSH = 5S ; 5s is the default value
  • Set the following environment variables:
GITEA_SLOW_TEST_TIME="10s" GITEA_SLOW_FLUSH_TIME="5s" make test-sqlite

Tips and tricks

If you know noteworthy tests that can act as an inspiration for new tests, please add some details here.