mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2025-06-25 18:40:51 +00:00
3bb6ed8f19
Some checks are pending
/ release (push) Waiting to run
testing / backend-checks (push) Waiting to run
testing / frontend-checks (push) Waiting to run
testing / test-unit (push) Blocked by required conditions
testing / test-e2e (push) Blocked by required conditions
testing / test-remote-cacher (redis) (push) Blocked by required conditions
testing / test-remote-cacher (valkey) (push) Blocked by required conditions
testing / test-remote-cacher (garnet) (push) Blocked by required conditions
testing / test-remote-cacher (redict) (push) Blocked by required conditions
testing / test-mysql (push) Blocked by required conditions
testing / test-pgsql (push) Blocked by required conditions
testing / test-sqlite (push) Blocked by required conditions
testing / security-check (push) Blocked by required conditions
This PR is part of https://codeberg.org/forgejo/forgejo/pulls/4767 filed by @algernon To keep changes isolated this might be reviewed & merge after https://codeberg.org/forgejo/forgejo/pulls/7714 Refactor existing code to have one AP struct per file. Enhance AP structs needed by related PR ## Checklist The [contributor guide](https://forgejo.org/docs/next/contributor/) contains information that will be helpful to first time contributors. There also are a few [conditions for merging Pull Requests in Forgejo repositories](https://codeberg.org/forgejo/governance/src/branch/main/PullRequestsAgreement.md). You are also welcome to join the [Forgejo development chatroom](https://matrix.to/#/#forgejo-development:matrix.org). ### Tests - I added test coverage for Go changes... - [x] in their respective `*_test.go` for unit tests. ### Release notes - [x] I do not want this change to show in the release notes. - [ ] I want the title to show in the release notes with a link to this pull request. - [ ] I want the content of the `release-notes/<pull request number>.md` to be be used for the release notes instead of the title. Co-authored-by: zam <mirco.zachmann@meissa.de> Co-authored-by: Mirco Zachmann <nostar@noreply.codeberg.org> Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/7728 Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org> Co-authored-by: Michael Jerger <michael.jerger@meissa-gmbh.de> Co-committed-by: Michael Jerger <michael.jerger@meissa-gmbh.de>
74 lines
2.4 KiB
Go
74 lines
2.4 KiB
Go
// Copyright 2023, 2024, 2025 The Forgejo Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package forgefed
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestActorNew(t *testing.T) {
|
|
sut, err := NewActorID("https://an.other.forgejo.host/api/v1/activitypub/user-id/5")
|
|
require.NoError(t, err)
|
|
assert.Equal(t, ActorID{
|
|
ID: "5",
|
|
HostSchema: "https",
|
|
Path: "api/v1/activitypub/user-id",
|
|
Host: "an.other.forgejo.host",
|
|
HostPort: 443,
|
|
UnvalidatedInput: "https://an.other.forgejo.host/api/v1/activitypub/user-id/5",
|
|
IsPortSupplemented: true,
|
|
}, sut)
|
|
|
|
sut, err = NewActorID("https://an.other.forgejo.host/api/v1/activitypub/actor")
|
|
require.NoError(t, err)
|
|
assert.Equal(t, ActorID{
|
|
ID: "actor",
|
|
HostSchema: "https",
|
|
Path: "api/v1/activitypub",
|
|
Host: "an.other.forgejo.host",
|
|
HostPort: 443,
|
|
UnvalidatedInput: "https://an.other.forgejo.host/api/v1/activitypub/actor",
|
|
IsPortSupplemented: true,
|
|
}, sut)
|
|
|
|
sut, err = NewActorID("https://an.other.gts.host/users/me")
|
|
require.NoError(t, err)
|
|
assert.Equal(t, ActorID{
|
|
ID: "me",
|
|
HostSchema: "https",
|
|
Path: "users",
|
|
Host: "an.other.gts.host",
|
|
HostPort: 443,
|
|
UnvalidatedInput: "https://an.other.gts.host/users/me",
|
|
IsPortSupplemented: true,
|
|
}, sut)
|
|
}
|
|
|
|
func TestActorIdValidation(t *testing.T) {
|
|
sut := ActorID{}
|
|
sut.HostSchema = "https"
|
|
sut.Path = "api/v1/activitypub/user-id"
|
|
sut.Host = "an.other.host"
|
|
sut.HostPort = 443
|
|
sut.IsPortSupplemented = true
|
|
sut.UnvalidatedInput = "https://an.other.host/api/v1/activitypub/user-id/"
|
|
result := sut.Validate()
|
|
assert.Len(t, result, 1)
|
|
assert.Equal(t, "ID should not be empty", result[0])
|
|
|
|
sut = ActorID{}
|
|
sut.ID = "1"
|
|
sut.HostSchema = "https"
|
|
sut.Path = "api/v1/activitypub/user-id"
|
|
sut.Host = "an.other.host"
|
|
sut.HostPort = 443
|
|
sut.IsPortSupplemented = true
|
|
sut.UnvalidatedInput = "https://an.other.host/api/v1/activitypub/user-id/1?illegal=action"
|
|
result = sut.Validate()
|
|
assert.Len(t, result, 1)
|
|
assert.Equal(t, "not all input was parsed, \nUnvalidated Input:\"https://an.other.host/api/v1/activitypub/user-id/1?illegal=action\" \nParsed URI: \"https://an.other.host/api/v1/activitypub/user-id/1\"", result[0])
|
|
}
|