luckyimnotanigger/tun2proxy
1
0
Fork 0
mirror of https://github.com/tun2proxy/tun2proxy.git synced 2025-06-23 01:20:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Enable virtual DNS by default for the CLI.

Browse source 
This commit enables virtual DNS by default for the CLI.

Pros for this decision:
  - It works out of the box in most cases.
  - Users do not need to install third-party software.
  - Users do not need to update their /etc/resolv.conf.

Cons:
  - Not every server might support this.
  - Hijacking port 53 without asking is somewhat intrusive.

Also, make the --dns argument an enum type. In the future, native
support for DNS over TCP/TLS might be added. In that case we could e.g.
supply tcp://1.1.1.1 to the --dns argument without breaking the CLI.
This commit is contained in:
B. Blechschmidt 2023-03-23 21:59:18 +01:00
parent 7695ba9c39
commit 6b7f550e7a
3 changed files with 20 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

22
src/main.rs
View file

@ -12,13 +12,25 @@ struct Args {
#[arg(short, long, value_name = "name", default_value = "tun0")]
tun: String,
/// The proxy URL in the form proto://[username[:password]@]host:port
/// Proxy URL in the form proto://[username[:password]@]host:port
#[arg(short, long, value_parser = Proxy::from_url, value_name = "URL")]
proxy: Proxy,
/// Enable virtual DNS feature
#[arg(short = 'd', long = "dns")]
virtual_dns: bool,
/// DNS handling
#[arg(
short,
long,
value_name = "method",
value_enum,
default_value = "virtual"
)]
dns: ArgDns,
}
#[derive(Copy, Clone, PartialEq, Eq, PartialOrd, Ord, clap::ValueEnum)]
enum ArgDns {
Virtual,
None,
}
fn main() {
@ -31,7 +43,7 @@ fn main() {
log::info!("Proxy {proxy_type} server: {addr}");
let mut options = Options::new();
if args.virtual_dns {
if args.dns == ArgDns::Virtual {
options = options.with_virtual_dns();
}