Fix project column edit (#34890)
Some checks are pending
release-nightly / nightly-binary (push) Waiting to run
release-nightly / nightly-docker-rootful (push) Waiting to run
release-nightly / nightly-docker-rootless (push) Waiting to run

Fix #34888
This commit is contained in:
wxiaoguang 2025-06-28 16:15:51 +08:00 committed by GitHub
parent e17dfce61b
commit 8df59fa11c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 4 additions and 3 deletions

View file

@ -130,12 +130,12 @@
<input class="project-column-id" type="hidden" name="id"> <input class="project-column-id" type="hidden" name="id">
<div class="required field"> <div class="required field">
<label class="project-column-title-label" for="project-column-title-input">title</label> <label class="project-column-title-label" for="project-column-title-input">title</label>
<input id="project-column-title-input" name="title" value="{{.Title}}" required> <input id="project-column-title-input" name="title" required>
</div> </div>
<div class="field"> <div class="field">
<label class="project-column-color-label" for="project-column-color-input">color</label> <label class="project-column-color-label" for="project-column-color-input">color</label>
<div class="js-color-picker-input column"> <div class="js-color-picker-input column">
<input maxlength="7" placeholder="#c320f6" id="project-column-color-input" name="color" value="{{.Color}}"> <input maxlength="7" placeholder="#c320f6" id="project-column-color-input" name="color">
{{template "repo/issue/label_precolors"}} {{template "repo/issue/label_precolors"}}
</div> </div>
</div> </div>

View file

@ -114,7 +114,6 @@ function initRepoProjectColumnEdit(writableProjectBoard: Element): void {
window.location.reload(); // newly added column, need to reload the page window.location.reload(); // newly added column, need to reload the page
return; return;
} }
fomanticQuery(elModal).modal('hide');
// update the newly saved column title and color in the project board (to avoid reload) // update the newly saved column title and color in the project board (to avoid reload)
const elEditButton = writableProjectBoard.querySelector<HTMLButtonElement>(`.show-project-column-modal-edit[${attrDataColumnId}="${columnId}"]`); const elEditButton = writableProjectBoard.querySelector<HTMLButtonElement>(`.show-project-column-modal-edit[${attrDataColumnId}="${columnId}"]`);
@ -134,6 +133,8 @@ function initRepoProjectColumnEdit(writableProjectBoard: Element): void {
elBoardColumn.style.removeProperty('color'); elBoardColumn.style.removeProperty('color');
queryElemChildren<HTMLElement>(elBoardColumn, '.divider', (divider) => divider.style.removeProperty('color')); queryElemChildren<HTMLElement>(elBoardColumn, '.divider', (divider) => divider.style.removeProperty('color'));
} }
fomanticQuery(elModal).modal('hide');
} finally { } finally {
elForm.classList.remove('is-loading'); elForm.classList.remove('is-loading');
} }