mirror of
https://github.com/go-gitea/gitea.git
synced 2025-06-29 04:29:55 +00:00
0e629c545a
This PR fixes a state de-synchronization bug with the issue stopwatch, it resolves the issue by replacing the ambiguous `/toggle` endpoint with two explicit endpoints: `/start` and `/stop`. - The "Start timer" button now exclusively calls the `/start` endpoint. - The "Stop timer" button now exclusively calls the `/stop` endpoint. This ensures the user's intent is clearly communicated to the server, eliminating the state inconsistency and fixing the bug. --------- Signed-off-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
59 lines
1.6 KiB
Go
59 lines
1.6 KiB
Go
// Copyright 2019 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package issue
|
|
|
|
import (
|
|
"context"
|
|
|
|
"code.gitea.io/gitea/models/db"
|
|
issues_model "code.gitea.io/gitea/models/issues"
|
|
user_model "code.gitea.io/gitea/models/user"
|
|
"code.gitea.io/gitea/modules/log"
|
|
notify_service "code.gitea.io/gitea/services/notify"
|
|
)
|
|
|
|
// CloseIssue close an issue.
|
|
func CloseIssue(ctx context.Context, issue *issues_model.Issue, doer *user_model.User, commitID string) error {
|
|
dbCtx, committer, err := db.TxContext(ctx)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
defer committer.Close()
|
|
|
|
comment, err := issues_model.CloseIssue(dbCtx, issue, doer)
|
|
if err != nil {
|
|
if issues_model.IsErrDependenciesLeft(err) {
|
|
if _, err := issues_model.FinishIssueStopwatch(dbCtx, doer, issue); err != nil {
|
|
log.Error("Unable to stop stopwatch for issue[%d]#%d: %v", issue.ID, issue.Index, err)
|
|
}
|
|
}
|
|
return err
|
|
}
|
|
|
|
if _, err := issues_model.FinishIssueStopwatch(dbCtx, doer, issue); err != nil {
|
|
return err
|
|
}
|
|
|
|
if err := committer.Commit(); err != nil {
|
|
return err
|
|
}
|
|
committer.Close()
|
|
|
|
notify_service.IssueChangeStatus(ctx, doer, commitID, issue, comment, true)
|
|
|
|
return nil
|
|
}
|
|
|
|
// ReopenIssue reopen an issue.
|
|
// FIXME: If some issues dependent this one are closed, should we also reopen them?
|
|
func ReopenIssue(ctx context.Context, issue *issues_model.Issue, doer *user_model.User, commitID string) error {
|
|
comment, err := issues_model.ReopenIssue(ctx, issue, doer)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
notify_service.IssueChangeStatus(ctx, doer, commitID, issue, comment, false)
|
|
|
|
return nil
|
|
}
|