mirror of
https://codeberg.org/libreboot/gnulib.git
synced 2025-07-01 23:09:56 +00:00
mirror of git://git.sv.gnu.org/gnulib used by lbmk
9f48fb992a
Problems reported by Michael Debertol in <https://bugs.gnu.org/49239>. While looking into this, I spotted some more areas where the code and documentation did not agree, or where the documentation was unclear. The biggest change needed by coreutils is a new function filenvercmp that can compare byte strings containing NUL. * lib/filevercmp.c: Do not include sys/types.h, stdlib.h, string.h. Include idx.h, verify.h. (match_suffix): Remove, replacing all uses with calls to ... (file_prefixlen): ... this new function. Simplify it by avoiding the need for a confusing READ_ALPHA state variable. Change its API to something more useful, with a *LEN arg. it with a new *LEN arg. (file_prefixlen, verrevcmp): Prefer idx_t to size_t where either will do. (order): Change args to S, POS, LEN instead of just S[POS]. This lets us handle NUL bytes correctly. Callers changed. Verify that ints are sufficiently wide for its API. (verrevcmp): Don't assume that S1[S1_LEN] is a non-digit, and likewise for S2[S2_LEN]. The byte might not be accessible if filenvercmp is being called. (filevercmp): Reimplement by calling filenvercmp. (filenvercmp): New function, rewritten without the assumption that the inputs are null-terminated. Remove "easy comparison to see if strings are identical", as the use of it later (a) was undocumented, and (b) caused sort -V to be unstable. When both strings start with ".", do not skip past the "."s before looking for suffixes, as this disagreed with the documentation. * lib/filevercmp.h: Fix comments, which had many mistakes. (filenvercmp): New decl. * modules/filevercmp (Depends-on): Add idx, verify. Remove string. * tests/test-filevercmp.c: Include string.h. (examples): Reorder examples ".0" and ".9" that matched the code but not the documentation. The code has been fixed to match the documentation. Add some examples involving \1 so that they can be tried with both \1 and \0. Add some other examples taken from the bug report. (equals): New set of test cases. (sign, test_filevercmp): New functions. (main): Remove test case where the fixed filevercmp disagrees with strverscmp. Use test_filevercmp instead of filevercmp, so that we also test filenvercmp. Test the newly-introduced EQUALS cases. |
||
|---|---|---|
| build-aux | ||
| config | ||
| doc | ||
| etc/license-notices | ||
| examples | ||
| lib | ||
| m4 | ||
| modules | ||
| pygnulib | ||
| tests | ||
| top | ||
| .cvsignore | ||
| .gitattributes | ||
| .gitignore | ||
| cfg.mk | ||
| ChangeLog | ||
| check-AC_LIBOBJ | ||
| check-copyright | ||
| check-module | ||
| COPYING | ||
| DEPENDENCIES | ||
| gnulib-tool | ||
| gnulib-tool.py | ||
| gnulib-tool.py.TODO | ||
| Makefile | ||
| MODULES.html.sh | ||
| NEWS | ||
| posix-modules | ||
| README | ||
| STATUS-libposix | ||
| users.txt | ||
Please create and read the docs with $ cd doc $ make gnulib.html $ xdg-open gnulib.html or read the online manual at https://www.gnu.org/software/gnulib/manual/gnulib.html