remove todos (was already mostly solved)

This commit is contained in:
Helium314 2025-02-09 19:08:17 +01:00
parent d807e08195
commit e36a20719f
3 changed files with 4 additions and 2 deletions

View file

@ -65,6 +65,7 @@ fun TextInputDialog(
modifier = modifier, modifier = modifier,
title = title, title = title,
text = { text = {
// todo: this sometimes looks weird on start (like non-outlined field where the label is in the text field)
OutlinedTextField( OutlinedTextField(
value = value, value = value,
onValueChange = { value = it }, onValueChange = { value = it },

View file

@ -11,6 +11,7 @@ import androidx.compose.runtime.Composable
import androidx.compose.runtime.getValue import androidx.compose.runtime.getValue
import androidx.compose.runtime.mutableStateOf import androidx.compose.runtime.mutableStateOf
import androidx.compose.runtime.remember import androidx.compose.runtime.remember
import androidx.compose.runtime.saveable.rememberSaveable
import androidx.compose.runtime.setValue import androidx.compose.runtime.setValue
import androidx.compose.ui.Modifier import androidx.compose.ui.Modifier
import androidx.compose.ui.draw.scale import androidx.compose.ui.draw.scale
@ -167,7 +168,7 @@ fun createAdvancedSettings(context: Context) = listOf(
SwitchPreference(it, Defaults.PREF_ABC_AFTER_EMOJI) SwitchPreference(it, Defaults.PREF_ABC_AFTER_EMOJI)
}, },
Setting(context, Settings.PREF_CUSTOM_CURRENCY_KEY, R.string.customize_currencies) { setting -> Setting(context, Settings.PREF_CUSTOM_CURRENCY_KEY, R.string.customize_currencies) { setting ->
var showDialog by remember { mutableStateOf(false) } // todo: textInputDialog... var showDialog by rememberSaveable { mutableStateOf(false) }
Preference( Preference(
name = setting.title, name = setting.title,
onClick = { showDialog = true } onClick = { showDialog = true }

View file

@ -283,7 +283,7 @@ fun createAppearanceSettings(context: Context) = listOf(
) { keyboardNeedsReload = true } ) { keyboardNeedsReload = true }
}, },
Setting(context, Settings.PREF_SPACE_BAR_TEXT, R.string.prefs_space_bar_text) { setting -> Setting(context, Settings.PREF_SPACE_BAR_TEXT, R.string.prefs_space_bar_text) { setting ->
var showDialog by rememberSaveable { mutableStateOf(false) } // todo: textInputDialog... var showDialog by rememberSaveable { mutableStateOf(false) }
val prefs = LocalContext.current.prefs() val prefs = LocalContext.current.prefs()
Preference( Preference(
name = setting.title, name = setting.title,